-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage reports to Codacy #4454
Conversation
I just restarted the Travis job to see if it is picking up the environment variable correctly. |
5773549
to
7bad93d
Compare
65f87b4
to
0f3dc5a
Compare
Tested ACK A markdown file in the docs folder showing usage would be nice. I used these gradle cmds to see test harness coverage -- it worked.
|
There is still the error in the Travis log that it is not configured properly, although I have done it as documented in Codacy. I'll have a look at it soon again. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant. |
I did some testing in the past and the config argument was printed correctly, but still it didn't work in the setup. I'll have a more in-depth look soon. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant. |
In the course of boosting Bisq's code quality and resilience, here is an attempt to get code coverage reports.
Use Case "Keep track of test coverage"
We can configure travis to build
master
once a day. By doing this, codacy will display code coverage numbers and we can keep track of how we are doing.Use Case "Increase coverage"
Unfortunately, it seems that codacy only shows us numbers without the option to filter for packages. As a workaround, I have added a parameter
only
to the coverage report task. With that, one can view the coverage for a specific module which holds a "total" of the module instead of the total of the whole project.Running
./gradlew clean check
followed by./gradlew codeCoverageReport -Ponly=p2p
will output an html-formatted and easy to read report inbuild/reports/jacoco/codeCoverageReport/html/index.html
like so:Given a future project sets its goal to "reach 30% test coverage in p2p", we can easily check if the goal has been reached.
Todo for @ripcurlx