Improve dispute views #4446
Improve dispute views #4446
Conversation
When a dispute is reopened it now shows the chat text entry field.
Add report button: Generates report text of all disputes with more detailed information which should be used for reporting. Add "Dump text of all disputes" button for getting a text representation of all disputes including the messages. This is not used for report but might be useful for search, etc. Do not show legacy arbitration tabs (for traders as well for arbitrators) if no cases available. Add 3 new enum entries for Reason for dispute: OPTION_TRADE SELLER_NOT_RESPONDING WRONG_SENDER_ACCOUNT Hide NO_REPLY and PROTOCOL_VIOLATION in UI (still in code if we still need it and re-activate them)
|
Examples for reports: Dispute nr. 1 Dispute nr. 2 Summary of reasons for disputes: |
…-for-dispute-views
Add re-open dispute button to mediation views (not refund agent as there it might be dangerous if he would close 2 times and pay out twice. If a dispute was reopened and a message was sent afterwards the receiver will auto-reopen the dispute as well and the UI shows the number indicator. Add search field to traders dispute views. Fix DisputeMsgEvents which was handling only legacy arbitration cases and now uses mediation and refund agent. Used to update state in case the UI is not selected. Add "send private notification" button for mediators and refund agents. Add report button for mediators and refund agents Generates report text of all disputes with more detailed information which should be used for reporting. Add "Dump text of all disputes" button for getting a text representation of all disputes including the messages for mediators and refund agents. This is not used for report but might be useful for search, etc. Do not show legacy arbitration tabs (for traders as well for arbitrators) if no cases available. Add 5 new enum entries for Reason for dispute: OPTION_TRADE SELLER_NOT_RESPONDING WRONG_SENDER_ACCOUNT, TRADE_ALREADY_SETTLED, PEER_WAS_LATE Hide NO_REPLY, SCAM and PROTOCOL_VIOLATION in UI (still in code if we still need it and re-activate them).
| OPTION_TRADE, | ||
| SELLER_NOT_RESPONDING, | ||
| WRONG_SENDER_ACCOUNT, | ||
| TRADE_ALREADY_SETTLED, |
There was a problem hiding this comment.
Thanks, the TRADE_ALREADY_SETTLED is badly needed
|
It would be cool feature to have in the list of mediator tickets, to check block explorer API and display red or green depending if deposit TXID is spent or unspent. For example you can view the red or green arrows in this TX to see if UTXO has been spent or not https://mempool.space/bisq/tx/4b5417ec5ab6112bedf539c3b4f5a806ed539542d8b717e1c4470aa3180edce5 |
There was a problem hiding this comment.
ACK
Dispute nr. 215
Opening date: Aug 28, 2020 5:11:44 AM
Close date: Aug 29, 2020 5:32:02 PM
Dispute duration: 1 day, 12 hours, 20 minutes
Payment method: US Postal Money Order
Currency: US Dollar (USD)
Dispute opened by: Buyer as maker
Reason: PEER_WAS_LATE
Summary notes: Parties completed trade normally
|
The only additional change I would request is to make the report for a given cycle, i.e. give me a report for cycle 16, since it's hard to filter it all out by hand in text editor |
|
@wiz Will add a bit more in a new PR as well, like preparing for case when RA resigns (mediator signs result summary, RA can close without payout,...) |
|
@chimp1984 I propose that you make separate PRs for separate issues to make it easier to review. This PR was pretty hard to review even though it was conceptually pretty simple. |
|
@sqrrm Yes I agree. |
Add re-open dispute button to mediation views (not refund agent as
there it might be dangerous if he would close 2 times and pay out twice.
If a dispute was reopened and a message was sent afterwards the receiver
will auto-reopen the dispute as well and the UI shows the number
indicator.
Add search field to traders dispute views.
Fix DisputeMsgEvents which was handling only legacy arbitration cases
and now uses mediation and refund agent. Used to update state in case
the UI is not selected.
Add "send private notification" button for mediators and refund agents.
Add report button for mediators and refund agents
Generates report text of all disputes with more detailed information
which should be used for reporting.
Add "Dump text of all disputes" button for getting a text representation
of all disputes including the messages for mediators and refund agents.
This is not used for report but might be useful for search, etc.
Do not show legacy arbitration tabs (for traders as well for
arbitrators) if no cases available.
Add 5 new enum entries for Reason for dispute:
OPTION_TRADE
SELLER_NOT_RESPONDING
WRONG_SENDER_ACCOUNT,
TRADE_ALREADY_SETTLED,
PEER_WAS_LATE
Hide NO_REPLY, SCAM and PROTOCOL_VIOLATION in UI (still in code if we still
need it and re-activate them).
For testing there are several scenarios:
Important note to mediators:
Try to avoid to change the payout distribution as there is a case where that would lead to a failed trade. If one user has already accepted the earlier payout distribution and the other user accept the updated one an exception is thrown. It would be more effort to support that as well so I left that out.
If both users accept the new distribution all goes well, but the mediator cannot know that.