Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow remote debugging of background Bisq apps #4433

Merged
merged 5 commits into from
Aug 31, 2020
Merged

Allow remote debugging of background Bisq apps #4433

merged 5 commits into from
Aug 31, 2020

Commits on Aug 25, 2020

  1. Fix setUpScaffold() signature 

    Adds the missing String[] params to the method signature, so test cases
can pass any needed combination of options to the scaffolding setup
from a @BeforeAll method.
    @ghubstan
    ghubstan committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    ac3c6e0 View commit details
    Browse the repository at this point in the history

  2. Move :cli test.sh to :apitest mainnet-test.sh 

    * The bats test script was moved to the apitest subproject and renamed.

* Version tests were updated for release 1.3.7.

* The duplicated "test getoffers buy eur check return status" was
  replaced by a new "test getoffers sell eur check return status" test.

* The bats dependency was switched to bats-core because development
  has halted on https://github.com/sstephenson/bats/tree/master.
  The new bats repository is
          https://github.com/bats-core/bats-core/tree/master
    @ghubstan
    ghubstan committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    2c803ef View commit details
    Browse the repository at this point in the history

  3. Remove duplicated grpc stub creation logic 

    The :apitest GrpcStubs class was removed and recreated in the :cli
subproject, to be used by both :cli and :apitest.  CliMain was changed
to use the new GrpcStubs.
    @ghubstan
    ghubstan committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    cb6166c View commit details
    Browse the repository at this point in the history

  4. Remove redundant ApiTestConfig options 

    This change removes three options: runArbNodeAsDesktop,
runAliceNodeAsDesktop, and runBobNodeAsDesktop, which should have
been deleted when the supportingApps option was added.  The comma
delimited list of apps passed with the supportingApps option
now determines whether arbitration / bob / alice nodes are started as
desktops or daemons.
    @ghubstan
    ghubstan committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b9c1feb View commit details
    Browse the repository at this point in the history

  5. Allow remote debugging of background Bisq apps 

    A unique hard coded debug listening port is assigned to the different
Bisq app types in the BisqAppConfig enum, and background Bisq apps
will be started with remote debug options if the scaffold-setup method
is passed an --enableBisqDebugging=true option.

* Added enableBisqDebugging (default=false) option to ApiTestConfig.

* Added remoteDebugPort field to BisqAppConfig enum.

* Added debugOpts field to BisqApp (using BisqAppConfig#remoteDebugPort).

* Appends debugOpts to exported JAVA_OPTS environment variable if present.

* Removed messy quotes from BisqAppConfig enum javaOpts values.

* Removed redundant return statement from BisqApp#shutdown().
    @ghubstan
    ghubstan committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    4d12b8f View commit details
    Browse the repository at this point in the history