Optimize AssetService #4409
Merged
Optimize AssetService #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version had several performance issues: - We kept tradeStatistics in a lookup map in memory (about 40 MB) - We built up the StatefulAssets even if it was not used/needed. Building the StatefulAssets was an expensive call. - AssetTradeActivityCheck was only used for printing out statistics and called on startup causing performance cost. Optimized version: - We call build the StatefulAssets only on demand (user activates view). Method call takes now 22 ms. - We create a optimized lookup map with a tuple of the data we need and keep it as local variable. - We removed AssetTradeActivityCheck. Thanks to the profiling reporting from: bisq-network/proposals#199
Private constructors are OK if injection is used. Empty methods are also ok if requires for interface...
sqrrm
requested changes
Aug 21, 2020
There was a problem hiding this comment.
Looks good. Would prefer to have pure refactoring as separate commits for easier review.
Added a couple of suggestions before merging.
Needs review from @ManfredKarrer since it touches core/dao
desktop/src/main/java/bisq/desktop/main/dao/burnbsq/assetfee/AssetFeeView.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: sqrrm <[email protected]>
…ssetFeeView.java Co-authored-by: sqrrm <[email protected]>
Agree. Sorry. |
|
utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version had several performance issues:
Building the StatefulAssets was an expensive call.
called on startup causing performance cost.
Optimized version:
view). Method call takes now 22 ms.
and keep it as local variable.
Thanks to the profiling reporting from:
bisq-network/proposals#199