Maintain floor amount of 5.46 BSQ to prevent dust errors #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an offer is made using BSQ for trade fee, the BSQ amount is burnt by doing a send-to-self. However if the BSQ change is below the bitcoin dust limit this causes an error. We fix this by maintaining a floor amount of 5.46 BSQ. Fixes #4372
ripcurlx
approved these changes
Jul 29, 2020
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an offer is made using BSQ for trade fee, the BSQ amount is burnt by doing a send-to-self. However if the BSQ change
is below the bitcoin dust limit this causes an error. We fix this by maintaining a floor amount of 5.46 BSQ.
Fixes #4372, more info here #4372 (comment)