Fix altcoin instant account creation / deletion issues #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon creating an altcoin instant account the limitations field should reflect that the trade duration is 1 hour. This was not working. The fix is to update that field dynamically based on the setting of the 'Trade instant' checkbox. Fixes #4361
|
ACK (tested) |
Altcoin instant accounts could not be removed using the delete button because the account retrieved for deletion did not match any of the ones known to bisq. This was due to the timestamp on the record being erroneously updated to the current time. Fixes 4364
ghost
changed the title
ghost
mentioned this pull request
|
ACK |
ripcurlx
approved these changes
Jul 23, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon creating an altcoin instant account the limitations field should reflect that the trade duration is 1 hour. This was not working. The fix is to update that field dynamically based on the setting of the 'Trade instant' checkbox.
Fixes #4361
Altcoin instant accounts could not be removed using the delete button because the account retrieved for deletion did not match any of the ones known to bisq. This was due to the timestamp on the record being erroneously updated to the current time.
Fixes #4364