Arbitrator witness signing #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add orphaned witness log
Better filter for root signedwitnesses Add debug keyboard shortcuts: - ctrl+shift+L -> logSignedWitnesses - ctrl+shift+S -> logSigners
Improve debug logging. Lower level from warning to info Fix broken test Add example code to clean out unnecessary SignedWitnesses
Legacy arbitrator can sign unsigned signed witness signer pubkeys To sign, from legacy arbitrator support, ctrl+O
This was referenced Jun 16, 2020
|
@sqrrm Could you please resolve the conflict? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a way for legacy arbitrators to repair some of the lost data in the signedwitness store. With ctrl+O from legacy arbitrator support view
SignUnsignedPubKeysWindowis opened.There is no change to current behavior of Bisq for a normal user in this PR.
Some more debug log shortcuts have been added as ctrl+shift+key under
PaymentAccountsViewAt the moment
SignSpecificWitnessWindowis not that interesting, but it might be a good thing to have in the future. It's a way for arbitrators to sign specificAccountAgeWitnesses.Some logging code from
AccountAgeWitnessServicewas moved to a separate class.cleanSignedWitnessesinSignedWitnessServiceis not yet in use, but it should probably be used soon. I don't want to enable it in this PR as it would change current behavior, and it also needs persistence to be fixed.