WIP Bitcoinj usage refactor example #4269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Involves turning implicit dependencies into explicit method arguments. Code inside the method is only changed so much as to allow the move.
Reduce API access to reflect which BitcoinJ endpoints are used within low.PeerGroup and which outside it.
Realised that these constructors have to stay on the subclass. Would like to put them with the rest of BitcoinJ endpoints. This subclass+superclass setup is something I just came up with, might find something better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related project proposal: bisq-network/projects#30
This example PR is meant to be read commit by commit.
It's a simple refactor of
WalletConfigfocusing on movingPeerGrouprelated code. I chosePeerGroup, because it's probably the simplest important group of BitcoinJ endpoints. Moving code is the simplest (and least interesting) form of refactoring, but while doing it (similarly to shuffling puzzle pieces while solving a puzzle) you come up with more interesting refactorings, though it's a time-intensive process. This example is about that shuffling.There are a few quirks here that are still to be ironed out:
low.PeerGroupclashes with BitcoinJ's PeerGroup. Might come up with something better;PeerGroup extends PeerGroupProxyscheme has its upsides, but a few downsides too. Might come up with something better;PeerGroupProxyname clashes withSocks5Proxyand the like; naming isn't worked out in general;WalletConfigtolow.PeerGroupin this example might actually do better left in WalletConfig, which will require dissecting it further.