-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create order using the same tx fee specified at funding #4266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
May 17, 2020 16:59
ghost
marked this pull request as ready for review
June 4, 2020 22:57
Also resolves #4278. |
ghost
changed the title
[WIP] Create order using the same tx fee specified at funding
Create order using the same tx fee specified at funding
Jun 4, 2020
ghost
mentioned this pull request
Jun 11, 2020
@ghubstan Could you please review this PR as it relates to the API? |
Scenario:
Log excerpt of this scenario is below, full log is in #4278
|
This was referenced Jun 22, 2020
ghost
closed this
Jun 29, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue whereby updates from the fee API were causing Insufficient Funds exception. Since the wallet is funded with a specific amount (deposit+trade fee+txFee), that same amount has
to be used when the user confirms offer creation (which could be some time later).
Fixes #4227
Fixes #4278
Fixes #4336
Fixes #4327
Desktop Bisq
createAndGetOffer
needs to pass a fee value toCreateOfferService
butCoreApi::placeOffer
does not pass one, so had pass from there a dummy fee of Coin.ZERO which would equate to existing functionaliy, i.e. get current appropriate fee.@ghubstan and @bisq-network/bisq-devs , requesting your input here.