Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bugfix and typofix" #4238

Merged
merged 1 commit into from
May 6, 2020
Merged

Revert "Bugfix and typofix" #4238

merged 1 commit into from
May 6, 2020

Conversation

sqrrm
Copy link
Member

@sqrrm sqrrm commented May 5, 2020

Reverts #4212

cbeams
cbeams approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Note that I am unfamiliar with the changes here, and am giving this ACK based on @sqrrm's request for me to do so in Keybase #dev.

@sqrrm sqrrm merged commit 246d5ee into master May 6, 2020
@sqrrm
Copy link
Member Author

sqrrm commented May 6, 2020

This is a revert of a PR that I merged too soon. It touches DAO code that Manfred later NACKed.

@gabernard gabernard deleted the revert-4212-bugfix-and-typofix branch January 4, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeams cbeams cbeams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sqrrm @cbeams