Code

Refactor rpc server implementation#4199

Code

Merged

cbeams merged 50 commits intobisq-network:masterbisq-network/bisq:masterfrom cbeams:refactor-rpc-servercbeams/bisq:refactor-rpc-serverCopy head branch name to clipboardApr 29, 2020

+502-328

Commits

Commits on Apr 22, 2020

• Implement simple cleartext gRPC authentication

  Show description for fe9e57b
  ghubstan

  committed
  fe9e57b

  Copy full SHA for fe9e57b

Commits on Apr 23, 2020

• Inject Config directly into BisqGrpcServer

  Show description for 506e12d
  cbeams

  committed
  506e12d

  Copy full SHA for 506e12d

• Favor final fields declared one per line

  Show description for 3fba97c
  cbeams

  committed
  3fba97c

  Copy full SHA for 3fba97c

• Do not declare local variables as final

  Show description for 6490e97
  cbeams

  committed
  6490e97

  Copy full SHA for 6490e97

• Wrap method parameters according to convention

  cbeams

  committed
  864bd9a

  Copy full SHA for 864bd9a

• Simplify implementation of authenticate method

  cbeams

  committed
  bc88080

  Copy full SHA for bc88080

• Polish BisqCallCredentials style

  Show description for 24c245c
  cbeams

  committed
  24c245c

  Copy full SHA for 24c245c

• Rename AuthenticationInterceptor => TokenAuthInterceptor

  cbeams

  committed
  ca06582

  Copy full SHA for ca06582

• Use a single auth token vs username:password

  Show description for 1a133f4
  cbeams

  committed
  1a133f4

  Copy full SHA for 1a133f4

Commits on Apr 25, 2020

• Simplify implementation to a single main class

  cbeams

  committed
  31aed4b

  Copy full SHA for 31aed4b

• Update comments and console output

  cbeams

  committed
  04defcb

  Copy full SHA for 04defcb

• Use var declarations where appropriate

  cbeams

  committed
  3fe7848

  Copy full SHA for 3fe7848

• Refactor auth infrastructure naming

  cbeams

  committed
  e84123c

  Copy full SHA for e84123c

• Reduce AuthHeaderCallCredentials visibility to package-private

  cbeams

  committed
  d19581a

  Copy full SHA for d19581a

• Rename/repackage bisq.cli.{app.Bisq=>CliMain}

  cbeams

  committed
  0b338bb

  Copy full SHA for 0b338bb

• Handle OptionException gracefully

  Show description for 423b2ad
  cbeams

  committed
  423b2ad

  Copy full SHA for 423b2ad

• Print help text when no command is specified

  cbeams

  committed
  b67ad6c

  Copy full SHA for b67ad6c

• Print nested exception error message on connect failure

  cbeams

  committed
  c6e5670

  Copy full SHA for c6e5670

• Improve error handling

  Show description for 7bf854c
  cbeams

  committed
  7bf854c

  Copy full SHA for 7bf854c

• Use 'method' vs 'command' naming

  cbeams

  committed
  c1931d2

  Copy full SHA for c1931d2

• Refine help output

  cbeams

  committed
  42e9bb1

  Copy full SHA for 42e9bb1

• Refactor 'auth*' naming to 'password'

  Show description for 653856f
  cbeams

  committed
  653856f

  Copy full SHA for 653856f

• Reduce PasswordAuthInterceptor visibility to package-private

  Show description for 20f563a
  cbeams

  committed
  20f563a

  Copy full SHA for 20f563a

• Fix typo in help output

  cbeams

  committed
  d923d07

  Copy full SHA for d923d07

• Allow double-quoted multiword apiPassword

  Show description for 16c2efc
  ghubstan

  committed
  16c2efc

  Copy full SHA for 16c2efc

• Remove redundant text from console err msg

  Show description for 56f2923
  ghubstan

  committed
  56f2923

  Copy full SHA for 56f2923

Commits on Apr 26, 2020

• Revert 16c2efc

  Show description for dee5e4c
  ghubstan

  committed
  dee5e4c

  Copy full SHA for dee5e4c

• Handle OptionException immediately

  cbeams

  committed
  e10e29a

  Copy full SHA for e10e29a

• Shutdown channel using a JVM shutdown hook

  Show description for 0a2aac0
  cbeams

  committed
  0a2aac0

  Copy full SHA for 0a2aac0

• Declare channel outside try/catch

  Show description for b7fda8d
  cbeams

  committed
  b7fda8d

  Copy full SHA for b7fda8d

• Add expect-based cli test suite

  Show description for 510e84d
  

  cbeams

  and

  ghubstan

  committed
  510e84d

  Copy full SHA for 510e84d

• Clean up whitespace in cli-test.sh

  cbeams

  committed
  ceaf20a

  Copy full SHA for ceaf20a

• Move cli-test.sh => cli/test.sh

  Show description for a3f9faf
  cbeams

  committed
  a3f9faf

  Copy full SHA for a3f9faf

• Touch up test descriptions and parameter naming

  cbeams

  committed
  822e681

  Copy full SHA for 822e681

• Set --password as a required option in JOpt parser

  cbeams

  committed
  5fa7939

  Copy full SHA for 5fa7939

• Update cli/test.sh instructions

  Show description for f4b4f5a
  cbeams

  committed
  f4b4f5a

  Copy full SHA for f4b4f5a

• Add comment explaining exception message mangling

  cbeams

  committed
  f580349

  Copy full SHA for f580349

• Touch up help output

  Show description for a6a8702
  cbeams

  committed
  a6a8702

  Copy full SHA for a6a8702

• Revert marking password as required in JOpt parser

  Show description for 312ef30
  cbeams

  committed
  312ef30

  Copy full SHA for 312ef30

• Remove note to self

  ghubstan

  committed
  cfb7e32

  Copy full SHA for cfb7e32

Commits on Apr 27, 2020

• Remove StopServer rpc method

  Show description for 01580ae
  cbeams

  committed
  01580ae

  Copy full SHA for 01580ae

• Remove section comments from BisqGrpcServer

  cbeams

  committed
  f2028f2

  Copy full SHA for f2028f2

• Eliminate static fields in BisqGrpcServer

  cbeams

  committed
  a52be59

  Copy full SHA for a52be59

• Sort static inner classes at bottom

  cbeams

  committed
  376d11d

  Copy full SHA for 376d11d

• Rename gRPC service classes from *{Impl=>Service}

  cbeams

  committed
  edbc81c

  Copy full SHA for edbc81c

• Make gRPC service classes non-static

  Show description for 1f8839e
  cbeams

  committed
  1f8839e

  Copy full SHA for 1f8839e

• Use var declarations where appropriate

  cbeams

  committed
  2f7d0f6

  Copy full SHA for 2f7d0f6

• Rename BisqGrpcServer => GrpcServer

  cbeams

  committed
  a33e030

  Copy full SHA for a33e030

• Refine GrpcServer log output

  cbeams

  committed
  82f1b66

  Copy full SHA for 82f1b66

• Add 'apiPort' configuration option

  cbeams

  committed
  3badf29

  Copy full SHA for 3badf29