Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the BSQ amount correctly in issuance log message #4177

Merged
merged 1 commit into from Apr 17, 2020
Merged

Display the BSQ amount correctly in issuance log message #4177

merged 1 commit into from Apr 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2020

Fixes #3709. The issuance log message displayed the issued BSQ with 2 extra zeros (i.e. sats value). This was because BSQ is represented internally within the application as sats, so it has to
be converted by MathUtils.scaleDownByPowerOf10(amount, 2) whenever displayed to the user.

Before fix:

We issued new BSQ to tx with ID 556aeeedca108aaf04bb3ff067802a212fdc751f2ed15b45d19dbcfe44aee3cd
Issued BSQ: 1000000
Issuance type: REIMBURSEMENT

After fix:

We issued new BSQ to tx with ID 556aeeedca108aaf04bb3ff067802a212fdc751f2ed15b45d19dbcfe44aee3cd
Issued BSQ: 10000.0
Issuance type: REIMBURSEMENT

Display the BSQ amount correctly in issuance log message
f49445e 
Fixes #3709.  The issuance log message displayed the issued BSQ
with 2 extra zeros (i.e. sats value).  This was because BSQ is
represented internally within the application as sats, so it has to
be converted by `MathUtils.scaleDownByPowerOf10(amount, 2)`
whenever displayed to the user.
ripcurlx
ripcurlx approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 4fd8be6 into bisq-network:master Apr 17, 2020
@ghost ghost deleted the fix_issue_3709 branch April 17, 2020 16:47
@ripcurlx ripcurlx added this to the v1.3.3 milestone Apr 28, 2020
@ghost ghost mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.4
Development

Successfully merging this pull request may close these issues.

Wrong BSQ amount in issuance log message
1 participant
@ripcurlx