Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disputes
This PR adds a filter to signed witness pubkeys, which are used as the identifier in the signing tree. If a pubkey is filtered the witnesses dependent on that key will also be invalidated.
Example:
w1 and w6 are filtered, causing all dependent witnesses to be filtered as well (all the prime
'
witnesses in the graph). In this example only w2, w5 and w9 are still considered signed.Bad data fix
A fix to how already signed witnesses are retrieved (
SignedWitnessService.getVerifiedWitnessDateList
) also affects cases where some data in the signed tree is missing, as seen in #3931.The extra check
will cause a verification each time rather than allowing to start a trade without checking and later being surprised that the counterparty isn't signed.
For now this will likely cause some issues for the CAD market for people that have already signed accounts but that are missing an ancestor signed witness data item. It will avoid any surprises with users not getting signed where they expect it though.