Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guava dependency to seednode #4116

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

ghubstan
Copy link
Contributor

@ghubstan ghubstan commented Apr 2, 2020

Merging PR #4096, which moved protobuf defs out of core and common,
left :seednode without its required dependency on guava, causing
NoSuchMethodErrors.

Merging PR bisq-network#4096, which moved protobuf defs out of core and common,
left :seednode without its required dependency on guava, causing
NoSuchMethodErrors.
@ghubstan ghubstan requested a review from cbeams as a code owner April 2, 2020 16:45
@wiz
Copy link
Contributor

wiz commented Apr 2, 2020

@ghubstan would this have caused #4110 ?

@ripcurlx
Copy link
Contributor

ripcurlx commented Apr 2, 2020

@ghubstan would this have caused #4110 ?

Yes, I think that is it.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Solved the problem for me

@ripcurlx ripcurlx merged commit f4257bf into bisq-network:master Apr 2, 2020
@ghubstan
Copy link
Contributor Author

ghubstan commented Apr 2, 2020

@ghubstan would this have caused #4110 ?

@wiz, yes... profuse apologies

@wiz
Copy link
Contributor

wiz commented Apr 2, 2020

No need to apologize bro we were just trying to figure out if it was a problem with my seednode installation script. Thanks for fixing 👍

@ghubstan ghubstan deleted the add-guava-dep-to-seednode branch April 2, 2020 21:01
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants