Add onion address for @robkaandorp's btcnode #4100
Conversation
Network proposal bisq-network/proposals#189
|
Thanks for opening this pull request! |
|
@robkaandorp Please sign your commit and I'm happy to merge your PR. @wiz As we haven't defined it yet: Is a fixed IP and a DNS entry a requirement for BTC Core node operators? |
|
This is totally fine, and currently @Emzy is running a Tor-only Bitcoin node, since he doesn't have a static IP address for that node. My understanding of the Bisq code is that you can optionally omit either the Tor onion or the clearnet IP/hostname and it handles this fine. As we scale Bisq larger and require more Bitcoin nodes, and as moore's law progresses, I can see a future where all Bisq contributors simply run a Raspberry Pi node at their house with a Tor onion only, so we don't need to pay monthly hosting costs for Bitcoin nodes. We can allocate some of the ops budget to one-time $100 purchases of raspberry pi setups for contributors, instead of spending $50 per month for hosting somewhere. |
|
Thanks @wiz for your comment. So please @robkaandorp just sign your commit as mentioned by the boring-cyborg and I'll merge this PR.
|
Replaced the Scanner input read loop with upgraded joptsimple dependency. Cli now takes a single, non-option program argument, runs it and exits. Also removed the "stop client" command because there is no input loop, but shutdown() is called for orderly channel shudown before the jvm terminates. Also changed cmd syntax from camel case to lowercase, mimicking bitcoin-cli. Configured logback to supress all debug & info level netty output, and bypassed logback to print results to System.out.
Change member name OptionParser cmdParser -> parser. Change server listening port to 9998, client port to 9998. Change constructor argument from String[] param -> args. Print the result only, w/out exec time. Handle help command & print that to stdout; print help triggered by user error to stderr. Use explicit system SUCCESS/FAIL codes in System.exit(0 || 1).
This commit fixes #4103, where it was demonstrated that a bisq.properties file containing the following entries would cause Bisq to fail at startup: baseCurrencyNetwork=BTC_MAINNET bannedSeedNodes= bannedBtcNodes= bannedPriceRelayNodes=5bmpx76qllutpcyp The source of the problem was that the jOptSimple argument parsing library converts the empty value of bannedSeedNodes to a List<String> of size 1 where the 0th element of the list is an empty string. This empty string was then attempted to be converted into a new NodeAddress, causing a validation error. This conversion happened during Guice wiring, and manifested as a blank white screen appearing as wiring errors often do in Bisq. The fix is simple and surgical. We now filter out any empty string elements before attempting to convert the banned seed node value to a new node address. I have reviewed the other related options, such as bannedPriceRelayNodes and bannedBtcNodes, and they do not cause the problem described above, so no filtering or other changes have been made to the way they work.
Network proposal bisq-network/proposals#189