Sorting order of offers appropriately by min/max range #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ripcurlx
reviewed
Mar 17, 2020
Comment on lines
297
to
309
| if (newValue==TableColumn.SortType.DESCENDING) | ||
| amountColumn.setComparator(Comparator.comparing(o -> o.getOffer().getAmount(), Comparator.nullsFirst(Comparator.naturalOrder()))); | ||
| else | ||
| amountColumn.setComparator(Comparator.comparing(o -> o.getOffer().getMinAmount(), Comparator.nullsFirst(Comparator.naturalOrder()))); | ||
| }); | ||
| volumeColumn.sortTypeProperty().addListener((observable, oldValue, newValue) -> { | ||
| if (newValue==TableColumn.SortType.DESCENDING) | ||
| volumeColumn.setComparator(Comparator.comparing(o -> o.getOffer().getVolume(), Comparator.nullsFirst(Comparator.naturalOrder()))); | ||
| else | ||
| volumeColumn.setComparator(Comparator.comparing(o -> o.getOffer().getMinVolume(), Comparator.nullsFirst(Comparator.naturalOrder()))); | ||
| }); |
There was a problem hiding this comment.
As we had issues in the past concerning using no brackets for one line conditionals we decided to use always {}
ripcurlx
reviewed
Mar 17, 2020
desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java
Outdated
Show resolved
Hide resolved
ripcurlx
suggested changes
Mar 17, 2020
ghost
requested a review
from
ripcurlx
previously approved these changes
Mar 18, 2020
|
@jmacxx I just recognized that you haven't signed your commits. |
|
This change fixes an issue with sorting the offer list when the amount is shown as a range. In OfferBookView::activate() we add a listener for the sortTypeProperty on amountColumn and volumeColumn. When the sortType is changed we set the comparator to be the approprate property of the Offer; either getAmount/getMinAmount; getVolume/getMinVolume. Fixes #3818
ripcurlx
approved these changes
Mar 18, 2020
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3818
This change fixes an issue with sorting the offer list when the amount is shown as a range. The sort was hard coded on the top end of the range which does not make sense when sorting in ascending order.
In OfferBookView::activate() we add a listener for the sortTypeProperty on amountColumn and volumeColumn. When the sortType is changed we set the comparator to be the approprate property of the Offer; either getAmount/getMinAmount; getVolume/getMinVolume.