Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an empty dummy exchange rate to prevent warning logs #4043

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Add an empty dummy exchange rate to prevent warning logs #4043

merged 1 commit into from
Mar 10, 2020

Conversation

ripcurlx
Copy link
Contributor

No description provided.

@ripcurlx ripcurlx requested a review from cbeams as a code owner March 10, 2020 16:53
wiz
wiz approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
tested on http://gztmprecgqjq64zh.onion/getAllMarketPrices and no more errors in logs

sqrrm
sqrrm approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit ad7cbe6 into bisq-network:master Mar 10, 2020
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Mar 11, 2020
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Closed
@ripcurlx ripcurlx deleted the extend-cmc-stub-to-remove-warning-log branch July 16, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

@wiz wiz wiz approved these changes

@cbeams cbeams Awaiting requested review from cbeams

Assignees
No one assigned
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ripcurlx @wiz @sqrrm