Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce CoinMarketCap stub to prevent error in existing clients #4037

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Introduce CoinMarketCap stub to prevent error in existing clients #4037

merged 2 commits into from
Mar 9, 2020

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Mar 9, 2020

No description provided.

@ripcurlx ripcurlx requested a review from cbeams as a code owner March 9, 2020 13:55
sqrrm
sqrrm previously approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

wiz
wiz previously approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
seems working as I have the CMC placeholder now
http://gztmprecgqjq64zh.onion/getAllMarketPrices

@ripcurlx ripcurlx dismissed stale reviews from wiz and sqrrm via 537f3d4 March 9, 2020 14:23
sqrrm
sqrrm approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested by running local client against wiz's pricenode running this version

@sqrrm sqrrm merged commit 6a27ab0 into bisq-network:master Mar 9, 2020
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Mar 10, 2020
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Closed
@ripcurlx ripcurlx deleted the fix-cmc-pricenode-issue branch July 16, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

@wiz wiz wiz left review comments

@cbeams cbeams Awaiting requested review from cbeams

Assignees
No one assigned
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ripcurlx @wiz @sqrrm