Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bitcoinJ checkpoints and data stores #3965

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Update bitcoinJ checkpoints and data stores #3965

merged 2 commits into from
Feb 12, 2020

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Feb 11, 2020 •
edited
Loading

Light node in light mode and full node in dark mode.
Bildschirmfoto 2020-02-11 um 13 48 56
Bildschirmfoto 2020-02-11 um 13 48 52
Bildschirmfoto 2020-02-11 um 13 48 42
Bildschirmfoto 2020-02-11 um 13 48 46
Bildschirmfoto 2020-02-11 um 13 48 15
Bildschirmfoto 2020-02-11 um 13 48 35

@ripcurlx ripcurlx requested review from sqrrm and wiz February 11, 2020 12:52
@sqrrm
Copy link
Member

sqrrm commented Feb 12, 2020

I get a difference in the TradeStatistics2Store when I run from the resources from last release. That doesn't sound right. I think yours is missing something (possibly one of the duplicates, but it should be the same running from yours and the one from previous release. Could you please check on your side again.

The other data stores look correct.

@ripcurlx
Copy link
Contributor Author

I get a difference in the TradeStatistics2Store when I run from the resources from last release. That doesn't sound right. I think yours is missing something (possibly one of the duplicates, but it should be the same running from yours and the one from previous release. Could you please check on your side again.

You mean a difference in the number of entries? I'll debug a new live client from the old data store to check if I see different numbers in the trade statistic store compared to my v1.2.6 client

sqrrm
sqrrm approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit 580681e into bisq-network:master Feb 12, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Closed
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Feb 17, 2020
@sqrrm sqrrm mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

@wiz wiz Awaiting requested review from wiz

Assignees
No one assigned
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ripcurlx @sqrrm