Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix btcnode validation regex to handle multiple FQDNs, add tests #3964

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fix btcnode validation regex to handle multiple FQDNs, add tests #3964

merged 1 commit into from
Feb 11, 2020

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Feb 11, 2020

@devinbileck's PR #3961 fixed almost everything except one case for btcnode configuration, multiple FQDNs:

foo.example.com:8333,bar.example.com:8333

This PR fixes the FQDN regex to handle multiple cases and adds new testcases to verify

@wiz
Fix btcnode validation regex to handle multiple FQDNs, add tests
7f92d12 
 Please enter the commit message for your changes. Lines starting
ripcurlx
ripcurlx approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 64e4438 into bisq-network:master Feb 11, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Closed
@wiz wiz mentioned this pull request Feb 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiz @ripcurlx