Code

Refactor option handling#3889

Code

Merged

sqrrm merged 93 commits intobisq-network:masterbisq-network/bisq:masterfrom cbeams:refactor-option-handlingcbeams/bisq:refactor-option-handlingCopy head branch name to clipboardJan 21, 2020

+2,839-2,361

Commits

Commits on Jan 20, 2020

• Introduce Config as replacement for BisqEnvironment

  Show description for b34d59c
  cbeams

  committed
  b34d59c

• Move 'referralId' option handling from BisqEnvironment to Config

  cbeams

  committed
  cdaa901

• Move 'useDevMode' option handling from BisqEnvironment to Config

  cbeams

  committed
  70bdccb

• Move 'btcNetworkDir' and co from BisqEnvironment to Config

  cbeams

  committed
  f3e0b85

• Move 'useDevPrivilegeKeys' option handling from BisqEnvironment to Config

  cbeams

  committed
  f029fea

• Remove BisqException parser calls for options already moved to Config

  Show description for 6c1ef59
  cbeams

  committed
  6c1ef59

• Move 'dumpStatistics' option handling from BisqEnvironment to Config

  cbeams

  committed
  e2781c1

• Finish moving baseCurrencyNetwork option handling to Config

  cbeams

  committed
  ceac8bb

• Finish moving 'appDataDir' option handling to Config

  Show description for a194107
  cbeams

  committed
  a194107

• Finish moving 'userDataDir' option handling to Config

  cbeams

  committed
  e0766af

• Remove long-unused core.btc.UserAgent class

  Show description for 1842c47
  cbeams

  committed
  1842c47

• Finish moving 'appName' option handling to Config

  cbeams

  committed
  6a20013

• Move 'maxMemory' option handling to Config

  Show description for 849bd7c
  cbeams

  committed
  849bd7c

• Remove unused 'desktopWithHttpApi' option handling

  cbeams

  committed
  13db767

• Move 'ignoreDevMsg' option handling to Config

  cbeams

  committed
  051c532

• Move 'providers' option handling to Config

  Show description for a720475
  cbeams

  committed
  a720475

• Remove now unused AppOptionKeys class

  cbeams

  committed
  a2f5d5a

• Finish moving 'logLevel' option handling to Config

  cbeams

  committed
  f6319fe

• Remove now unused CommonOptionKeys class

  cbeams

  committed
  7be2ff1

• Move 'seedNode' option handling to Config

  Show description for e118165
  cbeams

  committed
  e118165

• Move 'banList' option handling to Config

  cbeams

  committed
  c56c06d

• Finish moving 'nodePort' option handling to Config

  cbeams

  committed
  ef7196e

• Move 'useLocalhostForP2P' option handling to Config

  cbeams

  committed
  0e48a3e

• Move 'maxConnections' option handling to Config

  cbeams

  committed
  8d6dbad

• Move 'socks5ProxyBtcAddress' option handling to Config

  cbeams

  committed
  5c02b12

• Move 'socks5ProxyHttpAddress' option handling to Config

  cbeams

  committed
  5a0683e

• Move 'torrcFile' option handling to Config

  cbeams

  committed
  fea3a64

• Move 'torrcOptions' option handling to Config

  cbeams

  committed
  923ec69

• Move 'torControlPort' option handling to Config

  Show description for d25ad0d
  cbeams

  committed
  d25ad0d

• Move 'torControlPassword' option handling to Config

  cbeams

  committed
  5966d0d

• Move 'torControlCookieFile' option handling to Config

  cbeams

  committed
  e90b256

• Move 'torControlUseSafeCookieAuth' option handling to Config

  cbeams

  committed
  25604c1

• Move 'torStreamIsolation' option handling to Config

  cbeams

  committed
  ca3719a

• Move message throttle option handling to Config

  cbeams

  committed
  2dbd72b

• Make defaultUserDataDir field a local variable

  cbeams

  committed
  3002b16

• Remove obsolete NETWORK_ID option key

  Show description for 8e4107d
  cbeams

  committed
  8e4107d

• Remove now unused NetworkOptionKeys class

  cbeams

  committed
  326375e

• Rename Config.{NULL_INT=>DEFAULT_INT} for clarity

  cbeams

  committed
  be97190

• Finish moving 'bitcoinRegtestHost' option handling to Config

  cbeams

  committed
  769c62b

• Move Config.log declaration

  cbeams

  committed
  8528589

• Finish moving 'ignoreLocalBtcNode' option handling to Config

  cbeams

  committed
  4fb60a3

• Move 'btcNodes' option handling to Config

  cbeams

  committed
  5271d4d

• Move 'useTorForBtc' option handling to Config

  cbeams

  committed
  9003154

• Move 'socks5DiscoverMode' option handling to Config

  cbeams

  committed
  b7889dd

• Move 'useAllProvidedNodes' option handling to Config

  cbeams

  committed
  97cafaf

• Move 'userAgent' option handling to Config

  cbeams

  committed
  c8d739d

• Move 'numConnectionsForBtc' option handling to Config

  Show description for 99cf8c9
  cbeams

  committed
  99cf8c9

• Remove now unused BtcOptionKeys class

  Show description for 919c58e
  cbeams

  committed
  919c58e

• Move 'rpcUser' option handling to Config

  cbeams

  committed
  80754ed

• Move 'rpcPassword' option handling to Config

  cbeams

  committed
  b4d4ca4

• Move 'rpcHost' option handling to Config

  cbeams

  committed
  182f472

• Move 'rpcPort' option handling to Config

  cbeams

  committed
  86e1ae1

• Move 'rpcBlockNotificationPort' option handling to Config

  cbeams

  committed
  3841e6b

• Move 'rpcBlockNotificationHost' option handling to Config

  cbeams

  committed
  9a7eedb

• Move 'dumpBlockchainData' option handling to Config

  cbeams

  committed
  2995bc2

• Move 'fullDaoNode' option handling to Config

  cbeams

  committed
  519259b

• Move 'genesisTxId' option handling to Config

  cbeams

  committed
  6ea1464

• Move 'genesisBlockHeight' option handling to Config

  cbeams

  committed
  ca5b260

• Move 'genesisTotalSupply' option handling to Config

  cbeams

  committed
  aadf7c7

• Finish moving 'daoActivated' option handling to Config

  cbeams

  committed
  15c492b

• Remove now unused DaoOptionKeys class

  cbeams

  committed
  43fb851

• Finish moving 'useDevPrivilegeKeys' option handling to Config

  cbeams

  committed
  9ff6dd2

• Finish moving 'useDevMode' option handling to Config

  cbeams

  committed
  c6d0425

• Finish moving 'referralId' option handling to Config

  cbeams

  committed
  1216ba2

• Remove now unused BisqEnvironment class

  Show description for f5a1854
  cbeams

  committed
  f5a1854

• Replace uses of Spring CollectionUtils

  Show description for 2c78299
  cbeams

  committed
  2c78299

• Replace use of Spring's AnnotationUtils

  cbeams

  committed
  51a0e66

• Replace use of Spring's ClassUtils

  cbeams

  committed
  658df79

• Replace use of Spring's StringUtils

  cbeams

  committed
  75ab51d

• Eliminate dependency on Spring Framework

  Show description for c968ddf
  cbeams

  committed
  c968ddf

• Broaden BisqExcutable exception handling

  Show description for 6d6d41b
  cbeams

  committed
  6d6d41b

• Make ConfigException extend BisqException

  Show description for 022b5f1
  cbeams

  committed
  022b5f1

• Catch ConfigException as contingency, Throwble as fault

  Show description for 7382344
  cbeams

  committed
  7382344

• Remove now unused BisqExecutable option handling

  Show description for 3f605f8
  cbeams

  committed
  3f605f8

• Replace HelpRequested exception with Config.isHelpRequested()

  cbeams

  committed
  b5503a5

• Remove ConnectionConfig console output

  cbeams

  committed
  4779417

• Remove TestConfig in favor of reworked Config ctors

  cbeams

  committed
  e67746b

• Extract Config.APP_DATA_DIR constant

  cbeams

  committed
  a02eea9

• Add comments to Config and reorder a few things

  Show description for 174d2a9
  cbeams

  committed
  174d2a9

• Normalize creation of appDataDir and subdirs

  Show description for 3a6b0ce
  cbeams

  committed
  3a6b0ce

• Introduce and document static Config.baseCurrencyNetwork()

  Show description for 42a037e
  cbeams

  committed
  42a037e

• Introduce and document static Config.appDataDir()

  Show description for 4ea3290
  cbeams

  committed
  4ea3290

• Introduce LocalBitcoinNode and tests

  Show description for 876b91e
  cbeams

  committed
  876b91e

• Move Config.getOsUserDataDir to BisqExecutable.osUserDataDir

  Show description for 9460376
  cbeams

  committed
  9460376

• Rename and reorder test for nonexistent --configFile

  Show description for e1f54e9
  cbeams

  committed
  e1f54e9

• Qualify relative --configFile value with appDataDir

  Show description for 3d991e0
  cbeams

  committed
  3d991e0

• Throw if --configFile value does not exist

  Show description for 63489c1
  cbeams

  committed
  63489c1

• Introduce Config testing facilities

  Show description for fe50609
  cbeams

  committed
  fe50609

• Document Config and related types

  cbeams

  committed
  d5abc97

• Reorder a few of the most important options

  Show description for 4ac46e4
  cbeams

  committed
  4ac46e4

• Make Config option fields public and inline accessors

  Show description for 37b669c
  cbeams

  committed
  37b669c

• Avoid race condition in LocalBitcoinNodeTests

  Show description for efba975
  cbeams

  committed
  efba975

• Fix code quality issues

  Show description for dd5690f
  cbeams

  committed
  dd5690f