Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check existence of selected block explorer using name string comparison #3852

Merged

Conversation

wiz
Copy link
Member

@wiz wiz commented Jan 3, 2020

After further testing, I realized I introduced a bug in commit 4f4b0f6 because apparently the ArrayList.contains() method does not properly work for BlockChainExplorer object - to fix this I implemented a new contains() method that uses string comparison instead

After further testing, I realized I introduced a bug in commit
4f4b0f6 because apparently the
ArrayList.contains() method does not properly work for
BlockChainExplorer object - to fix this I implemented a new
contains() method that uses string comparison instead
@wiz wiz requested a review from ripcurlx as a code owner January 3, 2020 18:56
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 5883f70 into bisq-network:master Jan 3, 2020
@wiz wiz deleted the fix-block-explorer-validity-check branch January 3, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants