Refactorings for api support #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API will use getTradeStatistics and expect TradeStatistics2 not PersistableNetworkPayload
- Rename estimateTxSize to updateEstimatedFeeAndTxSize - Add getEstimatedFeeAndTxSize method to CreateOfferService - Add dependent methods and fields
- Use getBuyerSecurityDepositAsCoin and getSellerSecurityDepositAsCoin from CreateOfferService
- Use getEstimatedFeeAndTxSize from CreateOfferService for txFeeFromFeeService
freimair
approved these changes
Nov 18, 2019
ripcurlx
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For API access we need to move code for creating an offer to the core module.
https://github.com/chimp1984/bisq/tree/grpc is based on that code. This PR does not add anythign API related just prepares the required refactoring.