-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort existing gradle-witness.gradle #3585
Conversation
53b4e5d
to
84086df
Compare
I would love to see that in action! Thanks for showing that up! However, I suggest we implement signalapp/gradle-witness#34 ourselves, as the original seems to be unmaintained for quite some time and we have our own fork anyhow. As for the implementation part, I already did bisq-network/gradle-witness#2. For going forward, I suggest we get the implementation merged, and then add the resulting gradle-witness.jar in this PR and be done with it. |
@freimair I think your fix is better. But this PR also does sort the current contents of the file so it's a good start. |
@blabno, Chris has merged the changes in the gradle-witness repo. Would you build the new gradle-witness.jar and include the binary in this PR so we can get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - Could you please address #3585 (comment)?
84086df
to
37918f5
Compare
This should make comparison in future much easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. gradle-witness.jar checksum matches, library checksums did not change.
PR creator addressed the changes.
This should make comparison in future much easier.