Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce account age to chargeback risk payment methods #3580

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Re-introduce account age to chargeback risk payment methods #3580

merged 4 commits into from
Nov 11, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Nov 8, 2019 •
edited
Loading

We are not showing the account age info for payment methods that
have a high chargeback risk. This PR adds them back again.

Bildschirmfoto 2019-11-08 um 11 35 07
Bildschirmfoto 2019-11-08 um 11 35 20
Bildschirmfoto 2019-11-08 um 11 36 08

@ripcurlx ripcurlx requested a review from sqrrm as a code owner November 8, 2019 10:39
sqrrm
sqrrm requested changes Nov 8, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have look at comments, especially on the usage of account age category

desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java Outdated Show resolved Hide resolved
common/src/main/java/bisq/common/util/Tuple5.java Outdated Show resolved Hide resolved
common/src/main/java/bisq/common/util/Tuple5.java Outdated Show resolved Hide resolved
@sqrrm sqrrm mentioned this pull request Nov 11, 2019
Closed
@ripcurlx ripcurlx requested a review from sqrrm November 11, 2019 13:19
sqrrm
sqrrm approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit e0de998 into bisq-network:master Nov 11, 2019
@ripcurlx ripcurlx mentioned this pull request Nov 20, 2019
Closed
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Closed
@ripcurlx ripcurlx deleted the always-show-account-age-in-peer-info branch December 18, 2019 08:34
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ripcurlx @sqrrm