Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for empty validation #3573

Merged

Conversation

beingindot
Copy link
Contributor

@beingindot beingindot commented Nov 7, 2019

This commit is for github issue
fixes #3458
fixes #3459

Added empty validation check added for moneybeam and national bank transfer payment methods

chimp1984
chimp1984 previously approved these changes Nov 12, 2019
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@beingindot
Copy link
Contributor Author

Just pushed same commit as signed commit(included code reformat).

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Just move the one trim of the setAccountNameWithString to the PaymentMethodForm and utACk for the rest.

This commit is for github issue bisq-network#3458 and bisq-network#3459
check added for moneybeam and national bank transfer
@beingindot beingindot force-pushed the account_validate_mg_nationalbank branch from 133d40a to 755ca19 Compare November 13, 2019 15:48
@beingindot
Copy link
Contributor Author

@ripcurlx Have added the review changes. Pls check.

Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ripcurlx ripcurlx merged commit 459646a into bisq-network:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants