-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check for empty validation #3573
Added check for empty validation #3573
Conversation
desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralBankForm.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/paymentmethods/BankForm.java
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
31645f5
to
133d40a
Compare
Just pushed same commit as signed commit(included code reformat). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - Just move the one trim of the setAccountNameWithString to the PaymentMethodForm and utACk for the rest.
desktop/src/main/java/bisq/desktop/components/paymentmethods/BankForm.java
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java
Outdated
Show resolved
Hide resolved
This commit is for github issue bisq-network#3458 and bisq-network#3459 check added for moneybeam and national bank transfer
133d40a
to
755ca19
Compare
@ripcurlx Have added the review changes. Pls check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
This commit is for github issue
fixes #3458
fixes #3459
Added empty validation check added for moneybeam and national bank transfer payment methods