Add missing network capability for trade statistics hash update #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chimp1984 @sqrrm Could you review if my finding is correct? |
|
I think you're right. I don't have the time right now to test it though. |
It did solve the problem on two of my nodes. Unfortunately during my release smoke test I got two runtime trade stats for 1st of Nov and I thought everything is right now and we just didn't have any trades the day before because everyone was updating and too afraid to trade during this transitional period. |
|
Tested it now on three different live nodes and it seems to work now. Just waiting for an ACK from someone else. Also we need to decide if we want to shoot out another release soon (latest on Thursday). |
freimair
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we missed to add the new statistics hash capability to the core network capabilities.
At least this worked for me in my local nodes when I recognized some missing trade statistics.