Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch in Limbo with BisqException when last navigation no longer exists #3513

Merged
merged 2 commits into from Nov 1, 2019
Merged

Launch in Limbo with BisqException when last navigation no longer exists #3513

merged 2 commits into from Nov 1, 2019

Conversation

niyid
Copy link
Contributor

@niyid niyid commented Oct 29, 2019

Resolves issue #3510

@niyid niyid requested review from ripcurlx and sqrrm as code owners October 29, 2019 23:26
freimair
freimair approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@freimair freimair merged commit 8a44358 into bisq-network:master Nov 1, 2019
@freimair freimair mentioned this pull request Nov 1, 2019
Closed
ripcurlx
ripcurlx reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - The default link should have been OfferBookChartView.class not TradesChartsView.class. I'll create another PR fixing that.

@niyid
Copy link
Contributor Author

niyid commented Nov 5, 2019

@ripcurlx

Heh. Eating my lunch? :P J/K

@ripcurlx ripcurlx mentioned this pull request Nov 11, 2019
Closed
@chimp1984 chimp1984 mentioned this pull request Jan 9, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx left review comments

@freimair freimair freimair approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niyid @ripcurlx @freimair