Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2.0] Fix voteresultview #3500

Merged
merged 2 commits into from
Oct 28, 2019
Merged

[1.2.0] Fix voteresultview #3500

merged 2 commits into from
Oct 28, 2019

Conversation

sqrrm
Copy link
Member

@sqrrm sqrrm commented Oct 28, 2019

Fixes #3492 comments

chimp1984 and others added 2 commits October 27, 2019 19:12
@chimp1984
Check for result phase at activate method
09e68fa 
Fixes bisq-network#3487
@sqrrm
VoteResultView update results on any block in result phase
addeae5 
Avoid updating the result more than once per result phase but make
sure it's done if activated during the result phase
@sqrrm sqrrm requested a review from ripcurlx October 28, 2019 15:04
@sqrrm sqrrm mentioned this pull request Oct 28, 2019
Closed
@ripcurlx ripcurlx changed the title Fix voteresultview [1.2.0] Fix voteresultview Oct 28, 2019
ripcurlx
ripcurlx approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit a5ab477 into bisq-network:release/v1.2.0 Oct 28, 2019
@ripcurlx ripcurlx mentioned this pull request Nov 11, 2019
Closed
@sqrrm sqrrm mentioned this pull request Nov 11, 2019
Closed
@sqrrm sqrrm deleted the fix-voteresultview branch April 12, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sqrrm @ripcurlx @chimp1984