Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs related to Japan Bank Transfer payment method #3258

Merged
merged 3 commits into from
Sep 14, 2019

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Sep 13, 2019

  • Add missing call to addFormForBuyer(), improve BuyerStep2View UI
  • Fix Account Creation UI elements width to fill entire pane
  • Fix Account Creation UI elements padding to avoid overlap
  • Tweak trade display popup text and various strings
  • Remove @deprecated tag

* Add missing call to addFormForBuyer(), improve BuyerStep2View UI
* Fix Account Creation UI elements width to fill entire pane
* Fix Account Creation UI elements padding to avoid overlap
* Tweak trade display popup text and various strings
* Remove @deprecated tag
@wiz wiz requested review from ripcurlx and sqrrm as code owners September 13, 2019 21:39
@ripcurlx
Copy link
Contributor

Here is an unnecessary line break that creates this single "." in the next line.
Bildschirmfoto 2019-09-14 um 19 31 46
Bildschirmfoto 2019-09-14 um 19 46 08

To prevent scrolling the fields should be distributed more efficiently between the two columns.
Bildschirmfoto 2019-09-14 um 19 37 47
Bildschirmfoto 2019-09-14 um 19 46 36
It is still not perfect. Maybe for the next release we could combine two fields into one, so we don't have a scrollbar at all.

To save time I'll fix this issues and will push it directly to this branch.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - after my changes

@ripcurlx ripcurlx merged commit f9687ad into bisq-network:master Sep 14, 2019
ripcurlx pushed a commit that referenced this pull request Sep 14, 2019
* Fix various bugs related to Japan Bank Transfer payment method

* Add missing call to addFormForBuyer(), improve BuyerStep2View UI
* Fix Account Creation UI elements width to fill entire pane
* Fix Account Creation UI elements padding to avoid overlap
* Tweak trade display popup text and various strings
* Remove @deprecated tag

* Remove unnecessary line break

* Improve layout of fields
@wiz wiz deleted the fix-japan-bank-account-gui branch September 14, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants