-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new payment method: Japan Bank Transfer #3225
Merged
ripcurlx
merged 2 commits into
bisq-network:master
from
wiz:japan-bank-transfer-payment-method
Sep 13, 2019
Merged
Add new payment method: Japan Bank Transfer #3225
ripcurlx
merged 2 commits into
bisq-network:master
from
wiz:japan-bank-transfer-payment-method
Sep 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wow, the world has to learn a lot from Japan! |
wiz
force-pushed
the
japan-bank-transfer-payment-method
branch
from
September 9, 2019 00:51
5e19a6b
to
f2d93fd
Compare
ripcurlx
suggested changes
Sep 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wiz
force-pushed
the
japan-bank-transfer-payment-method
branch
2 times, most recently
from
September 12, 2019 00:29
94f8626
to
ea9c98a
Compare
wiz
force-pushed
the
japan-bank-transfer-payment-method
branch
2 times, most recently
from
September 13, 2019 01:08
528afb5
to
888b016
Compare
wiz
force-pushed
the
japan-bank-transfer-payment-method
branch
from
September 13, 2019 02:54
888b016
to
fb385a0
Compare
wiz
changed the title
[WIP] Add new payment method: Japan Bank Transfer (furikomi)
Add new payment method: Japan Bank Transfer
Sep 13, 2019
ripcurlx
approved these changes
Sep 13, 2019
I've reviewed now. It seems good. |
FKrauss
reviewed
Sep 21, 2019
desktop/src/main/java/bisq/desktop/components/paymentmethods/JapanBankTransferForm.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Japan Bank Transfer 🇯🇵
Summary
This PR adds support for Bisq trades using the Japanese Bankers Association (Zenginkyo) payment processing network, known casually to everyone in Japan as "furikomi".
Overview
Security
Compared to USA style bank accounts or Visa style credit cards, where anyone who knows your routing/account number can initiate fraudulent transfers out of your account, Japan's bank transfer system is secure:
Privacy
In Japan, your bank account details are not considered sensitive information:
Of course, banks and governments can see all transactions that flow through their systems. However, the nature of the transaction, and source of funds, etc. are not requested or recorded, as the transfer is fully electronic and not processed by humans. Because of this, ihe trading parties actually have decent privacy compared to other country's bank transfer methods. Additionally, no tax ID or other personal information are exchanged for the transaction, so it is very unlikely that users of this payment method will have their bank accounts frozen or shut down as a result.
Freedom
Since the system is inheriently secure, banks don't need to police the system:
The fully automated and electronic system does not censor transactions.
How it works
Account Information
To send a Japan Bank Transfer, the sender needs the following information:
Sending a Transfer
After the sender inputs the above data into their online banking, the receiving account holder's name is displayed to the sender so they can verify they are sending funds to the correct account before they finalize the transaction.
The transfer is usually completed almost instantly (less than 5 minutes), or on the next business day if the sender's bank does not support 24/7/365 transfers outside of normal banking hours.
Fraud Risks
If you transfer funds to an invalid account (i.e. the destination account is closed or cannot be located), the funds are automatically returned to the sender's account within 24 hours.
If you transfer funds to a valid account, once that accounts receives it (which is usually less than 2 minutes), you can request a chargeback if this transfer was a mistake. However, "The recipient bank will contact the payee and the funds will not be returned without the recipient's consent."[3]
If a stolen or hacked bank account is used to transfer funds to you, the bank will not reverse the transaction just because the account was hacked. The sender would have to go the police and utilize the court system to get refunded, but this is presumably hard to do, and not likely to happen unless transaction amount is very high.
Therefore, the Japan Bank Transfer payment method is requested to be added with "LOW" risk setting, which limits each trade to 0.5 BTC by default, and after multiplying by the current DAO parameter (200%), this means Japan Bank Transfers will be limited to 1 BTC per trade at this time of this PR.
Footnotes
"Japan population (ages 15+) 98.24%"
Source: World Bank Account ownership at a financial institution
URL: https://data.worldbank.org/indicator/FX.OWN.TOTL.ZS
"As of November 2008, it was reported as being the world's biggest deposit holder."
Source: Japan Post Bank, Wikipedia, the free encyclopedia
URL: https://en.wikipedia.org/wiki/Japan_Post_Bank
"振込先銀行より受取人に連絡し、受取人の了解がないと資金は戻りません。"
Source: Sumitomo Mitsui Banking Corporation support page on transfer reversals
URL: https://www.smbc.co.jp/kojin/direct/ib/help/help_kumimodoshi.html
Screenshots
Create Account
Form empty (English)
Form empty (Japanese)
Form filled (English)
Form filled (Japanese)
Bank search functionality
String validation for Japanese-only input fields
Trade limits
Display Account
Offer View
Maker view showing full details
Taker view showing Japan Bank Transfer payment method
Trade in progress (Japanese)
Trade requires attention for Buyer (Japanese)
Trade requires attention for Seller (English)
Trade information (English)
Trade information (Japanese)
Implementation Details
Input Validation
Bank Code: automatically entered from selected bank
Bank Name: must be selected from hard-coded list of 500 banks
Branch Name: must be Japanese characters
Branch Code: must be 3 digits
Account Name: must be Japanese characters
Account Number must be 4 ~ 8 digits
Account Type: radio buttons of 2 choices
Protobuf template
JSON contract payload