Update default fiat and crypto currencies #3179
Conversation
All altcoins have very low trading activity, other than Monero. I figured we should remove them all anyways, and make the user add those which they are interested in seeing. The only one they will see by default being BSQ.
|
@devinbileck You've to fix the PreferencesTest. If you have time to fix it right now, I'll wait for the codefreeze until you've updated this PR. |
|
@devin I just looked at the code part. I think this change needs to have some discussion as we are using it right now to push a couple of currencies. @ManfredKarrer @sqrrm @m52go might want to join this discussion as well. |
On the fiat side I agree that it might not make sense to have all other currencies there. On the Altcoin side we have to discuss which ones we want to keep to make it easier for new users to find their coin immediately. To select your Fiat and/or Altcoin market you want to trade in should be part of the future onboarding process. In that case we can remove all of them afterwards. |
|
Ah, good points. I will wait to receive feedback before proceeding. |
|
I don't think it is good to reduce the fiat currencies to the users default currency, as some users trade on several currencies and might be interested to look up other markets. With one currency it might give the impression Bisq is supporting only that currency for newbies. |
|
Also on altcoins I think we should keep a list of "recommended" coins. It is not only about trade volume but about coins which we think makes sense (e.g. Bitcoin Rhodium had high volume but is irrelevant long term, stablecoins will become important as alternative to fiat so we should promote those to make them more visible, as well as privacy coins like Grin - once added again). |
|
I confirm the multi fiat use case. On top of that I never traded against my locale-implied currency. |
Within the settings, the default list of displayed national currencies and altcoins is outdated, in terms of top traded, and most are unnecessary to be displayed for most users and a nuisance to have to remove (which I am sure is the first thing most users do).
I have updated it so that the preferred currency and only displayed national currency is chosen based on the users locale/county code, and the only altcoin displayed by default is BSQ. If the user wants anything else it is up to them to add it.
Before:
After:
