Add dropdown autocomplete on Market, Buy, Sell tabs #3139
Conversation
battleofwizards
force-pushed
the
add-autocomplete-on-market-buy-sell-tabs
branch
3 times, most recently
from
6520c7f to
bf51533
Compare
|
Here is a little teaser, click to watch a movie: |
You really want to get this PR merged soon 😉 |
|
utACK but how can this work when it doesn't add 10 new jar deps? 😂 |
|
Just got an exception when I typed into the search combobox in the markets offer book It did work after a restart, but it was weird to see this on the first time. Maybe a sync of the list in the background triggered this weird behavior. I'll give it a little more testing to see if I find the problem. |
|
It would be great if it would work that you select the selected market (e.g. EUR) and just type in your desired market (e.g. XMR) and replace and find it. Atm it writes the search term without the first character in front of the original market (e.g. mrEUR - Euro). It does work afterwards when selecting the text and typing in the desired market again. |
|
Thanks a lot @ripcurlx! I'm mostly worried about your exception b/c I cannot recreate it. Will try more. This needs to be fixed. I confirm the two UX glitches you mentioned. The ComboBox is half-magic internally and it is being embedded in a complex context. It is very hard to bend it to perfect autocomplete experience. I already spent much more time fighting this than I ever anticipated. OTOH I hate to deliver crap. I will see what I can do. |
|
@ripcurlx with what jdk did you run when you got that stacktrace? |
|
another stacktrace: |
battleofwizards
changed the title
Yeah, some of the JavaFX compontents are not really straight forward implemented.
I'm using OpenJDK 10 for development. |
|
@battleofwizards Congrats that you got so far!!! Beside @ripcurlx I don't know anyone who can master JavaFX component magic. |
battleofwizards
force-pushed
the
add-autocomplete-on-market-buy-sell-tabs
branch
2 times, most recently
from
d8d87bb to
9b8bdb3
Compare
battleofwizards
changed the title
|
The exceptions should now be fixed. The ComboBox was basically rewritten and now works with its own cloned list to avoid cross-thread sharing. The ComboBox list still gets updated on tab activation. Items should be fresh. The specific UX glitches found by @ripcurlx are worked around. Not strictly fixed but made less relevant. Some UX imperfections remain but I do not feel like I can improve this any further. At least not this time around. My recommendation is to merge as-is b/c it is strict improvement over no autocomplete at all. Ready for review! |
…#2226 Basic autocomplete feature for all dropdowns on the major tabs: * Market / Offer Book * Market / Trades * Buy BTC * Sell BTC Known limitations: * Autocomplete still missing from Settings, Account, DAO tabs * Minor UX glitches remain despite lots of debugging and polishing Related issues: * fix bisq-network#2226 * partially addressed bisq-network#2712 * superseded bisq-network#112
battleofwizards
force-pushed
the
add-autocomplete-on-market-buy-sell-tabs
branch
from
9b8bdb3 to
3f1b188
Compare
|
I'll review the PR before the code freeze. 👍 |
There was a problem hiding this comment.
ACK - Thanks for the contribution @battleofwizards! It looks like we have a new JavaFX expert 😄
|
Very cool to see this merged, thanks! Regarding JavaFX though the inconvenient truth is it was a brutal fight and many days going back and forth, rather than my expertise. |
battleofwizards
deleted the
add-autocomplete-on-market-buy-sell-tabs
branch
Basic autocomplete feature for all dropdowns on the major tabs:
Known limitations:
Related issues:
Note to reviewers:
The new code is mostly around the SearchComboBox and StringConverters. Other changes are mostly a necessary reshuffling of the existing code around ComboBox setup in the forms.