also run tests on jdk12 #3113
Merged
also run tests on jdk12 #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqrrm
reviewed
Aug 21, 2019
|
i made the change in one commit and then i reformatted the file with IDEA. |
|
My idea doesn't format this file at all, shouldn't .editorconfig handle this? Although it would use 4 space indents from what I understand so that this auto format of yours should be correct. |
|
maybe your older idea version does not format yaml files? |
|
anyway when a reformat changes the whole file i do it in a separate commit to make the changes easier to see |
|
Concept ACK. Thanks! |
ripcurlx
reviewed
Aug 27, 2019
christophsturm
force-pushed
the
travis-jdk12
branch
from
b18662a to
ac5fcc9
Compare
christophsturm
force-pushed
the
travis-jdk12
branch
from
ac5fcc9 to
9e17f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the build works on 10, 11 and 12, and the desktop app runs on 10 and 11, and with some minor problems on jdk12.
It makes no sense to ever officially support JDK11 because it is as unsupported as 10.
So I think we should run CI on jdk 10 to make sure we can build official binaries, and jdk 12 to make sure anyone with a supported JDK can contribute.