also fix singleton config for core module #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blabno
approved these changes
Aug 7, 2019
There was a problem hiding this comment.
The code looks good.
I see pros and cons in both approaches. Just as forgetting to configure class as singleton in a module you can forget about annotating the class. Defining life cycle inside module allows for class reuse in different context, but that's very theoretical benefit.
sqrrm
requested changes
Aug 13, 2019
| @@ -118,15 +84,6 @@ protected void configure() { | |||
| String referralId = environment.getProperty(AppOptionKeys.REFERRAL_ID, String.class, ""); | |||
| bind(String.class).annotatedWith(Names.named(AppOptionKeys.REFERRAL_ID)).toInstance(referralId); | |||
|
|
|||
| bind(MobileNotificationService.class).in(Singleton.class); | |||
| bind(MobileMessageEncryption.class).in(Singleton.class); | |||
There was a problem hiding this comment.
MobileMessageEncryption doesn't have singleton annotation and not tested in GuiceSetupTest.java
christophsturm
force-pushed
the
guice-core
branch
from
b0ef436 to
a8494a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #3058 that converts the core module too.
and unit test it all