Test guice setup and fix #3043
Merged
Test guice setup and fix #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: sqrrm <[email protected]>
christophsturm
force-pushed
the
test-guice-setup-and-fix
branch
from
e36f36f to
c1a29c2
Compare
christophsturm
force-pushed
the
test-guice-setup-and-fix
branch
from
58e867a to
f96edd2
Compare
christophsturm
commented
Aug 1, 2019
| @@ -97,6 +97,7 @@ public String toString() { | |||
|
|
|||
| @Inject | |||
| public KeyStorage(@Named(KEY_STORAGE_DIR) File storageDir) { | |||
| storageDir.mkdirs(); | |||
There was a problem hiding this comment.
the CI error came from a missing key directory on CI. I now changed the keystorage to create the directory if its missing. not sure if that has any downsides.
|
note that i had to bump guice to get a useful error message. I removed the guice bump again from this pr but we really should consider updating guice. |
|
can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sqrrm's guice fix and a unit test that checks seednode's guice setup. superseedes #3041