Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 1896 #3009

Merged
merged 7 commits into from Aug 9, 2019
Merged

Fix for issue 1896 #3009

merged 7 commits into from Aug 9, 2019

Conversation

niyid
Copy link
Contributor

@niyid niyid commented Jul 25, 2019 •
edited by freimair
Loading

Removing references to deprecated DefaultAddressValidator.

  • 7 coins were affected: Counterparty, Decred, EtherClassic, Namecoin, Siafund, Unobtanium, Zcoin
  • EtherAddressValidator was extended to allow passing of i18n resource key.
  • Message resource entries for validation errors were added to displayStrings.properties.

fixes #1896

@niyid
Copy link
Contributor Author

niyid commented Jul 25, 2019

Hi @ripcurlx,

As can be seen, I have created a new PR separately for issue 1896 as recommended.

Apologies for any inconvenience.

@niyid
Copy link
Contributor Author

niyid commented Jul 25, 2019 •
edited
Loading

I am just working on the build as project core which has the i18n resource class bisq.core.locale.Res is not set up as a dependency for project assets; rather core is a dependency for assets.

@niyid
To get around dependency of project assets on project core, a new class
48b2e7d 
was created to load the properties file.

Unit Test components for touched coins fixed.
@niyid niyid requested a review from ripcurlx as a code owner July 25, 2019 23:45
freimair
freimair approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Although I have not tested any small detail...

@ManfredKarrer
Copy link
Contributor

@freimair Please use utACK in case you have not fully tested the PR...

@freimair freimair mentioned this pull request Aug 9, 2019
Closed
@sqrrm sqrrm merged commit 1c5c633 into bisq-network:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freimair freimair freimair approved these changes

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update legacy assets with proper AddressValidator
4 participants
@niyid @ManfredKarrer @freimair @sqrrm