Fix offer editing for low volume offers #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For very low volume offers, it can happen that the minimum buyer security deposit by coin value is bigger than the maximum security deposit by percentage of trade amount. This caused the security deposit validity check in the offer editor to fail, making it impossible to edit these offers. This commit fixes the problem by setting the default percentage value to the model instead of the calculated one in this specific case.
sqrrm
reviewed
Jun 30, 2019
|
Strange... Can't reproduce it with my test offer. |
|
Open offer as: Attaching log but I don't think it's very interesting Looks like the amount defaults to 1 BTC after editing. It might not be related to your fix though. |
|
Oh, I think that's just the dev mode setting test values |
|
Indeed, I don't think I tried editing an offer while testing before. |
|
ACK Sorry, that was my bad with dev mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user on the forum had problems editing an offer:
https://bisq.community/t/alt-buy-offer-not-editable/7930
For very low volume offers, it can happen that the minimum buyer security
deposit by coin value is bigger than the maximum security deposit by
percentage of trade amount.
This caused the security deposit validity check in the offer editor to fail,
making it impossible to edit these offers.
This PR fixes the problem by setting the default percentage value to
the model instead of the calculated one in this specific case.