Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AckMessage failure #2917

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

devinbileck
Copy link
Member

When taking an offer, ack messages for
OfferAvailablilityRequest/Response were failing to be sent with the
following error.

Jun-23 22:35:38.129 [JavaFX Application Thread] ERROR
b.c.o.a.OfferAvailabilityProtocol: AckMessage for
OfferAvailabilityResponse failed. AckMessage=AckMessage{
uid='8779f9ae-22e9-4f16-bbbb-4da89fe23cdf',
senderNodeAddress=localhost:3333,
sourceType=OFFER_MESSAGE,
sourceMsgClassName='OfferAvailabilityResponse',
sourceUid='df1a50c5-c6e7-4c81-8ad4-a100d622a053',
sourceId='pexluolj-2e5e5d9f-5aca-4a3d-b66a-60b72afe3d2c-112',
success=true,
errorMessage='null'
} NetworkEnvelope{
messageVersion=12
}, makersNodeAddress=localhost:3632, errorMessage=We did not send the
EncryptedMessage because the peer does not support the capability.

When taking an offer, ack messages for
OfferAvailablilityRequest/Response were failing to be sent with the
following error.

> Jun-23 22:35:38.129 [JavaFX Application Thread] ERROR
> b.c.o.a.OfferAvailabilityProtocol: AckMessage for
> OfferAvailabilityResponse failed. AckMessage=AckMessage{
>      uid='8779f9ae-22e9-4f16-bbbb-4da89fe23cdf',
>      senderNodeAddress=localhost:3333,
>      sourceType=OFFER_MESSAGE,
>      sourceMsgClassName='OfferAvailabilityResponse',
>      sourceUid='df1a50c5-c6e7-4c81-8ad4-a100d622a053',
>      sourceId='pexluolj-2e5e5d9f-5aca-4a3d-b66a-60b72afe3d2c-112',
>      success=true,
>      errorMessage='null'
> } NetworkEnvelope{
>      messageVersion=12
> }, makersNodeAddress=localhost:3632, errorMessage=We did not send the
> EncryptedMessage because the peer does not support the capability.
@devinbileck devinbileck requested a review from ripcurlx as a code owner June 24, 2019 05:52
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit 7f3cec3 into bisq-network:master Jun 24, 2019
@devinbileck devinbileck deleted the fix-ack-message-failure branch June 24, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants