Fix getBlocks issue #2821
Merged
Fix getBlocks issue #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As soon we are over our connection target we start disconnecting seed nodes though that can be too early as getBlocks requests are still pending. We delay the disconnect seed handling to 3 minutes after our first connection so give it enough time to receive the getBlocksResponse.
Instead of the 3 minutes delay we set the flag from the lite node once the blocks are received. We delay 20 seconds to allow multiple getBlocksRequests to finish.
devinbileck
approved these changes
May 11, 2019
There was a problem hiding this comment.
ACK
Without this fix, I tested rebuilding the DAO state on mainnet and encountered the issue where I lost connection to all seednodes and was stuck synchronizing. I then tested again with this fix and it did not disconnect from the seeds and it successfully resynced the DAO state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disconnected seed nodes of we exceeded our connectionlimit which caused that getBlockResponses where not received. This PR fixes that.