[WIP] Use bisq's bitcoinj 0.15.1 #2772

oscarguindzberg · 2019-04-23T18:39:45Z

No description provided.

ManfredKarrer · 2019-04-23T23:14:42Z

I added WIP so that it does not get merged accidentally. I will not have time soon for review and it will require a solid review. We also need to deplay soon versions with the security improvements against the scammer and i prefer to not add a big change like that in that period. Sorry for that delay, looking forward to get it in but unfortunately a bit bad timing atm....

nopara73 · 2019-04-24T00:53:17Z

I added WIP so that it does not get merged accidentally.

Just a heads up: GitHub added Draft PRs those prevent merging. (Although you cannot downgrade a PR to be Draft, you have to start out with that.)

ManfredKarrer · 2019-04-27T18:05:46Z

Just a heads up: GitHub added Draft PRs those prevent merging. (Although you cannot downgrade a PR to be Draft, you have to start out with that.)

Thanks. We are using that once the PR maker knows that it cannot be merged soon. In that case @oscarguindzberg did not had the information about the current priority changes so I needed to add the WIP afterwards...

ManfredKarrer

utACK

I leave it to @ripcurlx when to merge as it require a profound test cycle for all wallet use cases and DAO tx use cases.

devinbileck · 2019-05-19T20:27:58Z

I ran into the following error when launching a seednode (as a DAO full node) on regtest. It appears to be caused by updating to guava 27. We need to update btcd-cli4j to use guava 27 as well.

May-17 16:15:57.793 [RpcService] ERROR b.c.d.n.f.RpcService: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V 
java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V
    at com.neemre.btcdcli4j.daemon.BtcdDaemonImpl.startMonitors(BtcdDaemonImpl.java:213)
    at com.neemre.btcdcli4j.daemon.BtcdDaemonImpl.<init>(BtcdDaemonImpl.java:53)
    at bisq.core.dao.node.full.RpcService.lambda$setup$2(RpcService.java:136)
    at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
    at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
    at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:844)
May-17 16:15:57.795 [SeedNodeMain] ERROR b.c.d.n.f.FullNode: An error occurred: Error=bisq.core.dao.node.full.RpcException: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V 
bisq.core.dao.node.full.RpcException: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V
    at bisq.core.dao.node.full.RpcService.lambda$setup$2(RpcService.java:153)
    at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
    at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
    at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:844)
Caused by: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V
    at com.neemre.btcdcli4j.daemon.BtcdDaemonImpl.startMonitors(BtcdDaemonImpl.java:213)
    at com.neemre.btcdcli4j.daemon.BtcdDaemonImpl.<init>(BtcdDaemonImpl.java:53)
    at bisq.core.dao.node.full.RpcService.lambda$setup$2(RpcService.java:136)
    ... 6 more
May-17 16:15:57.824 [SeedNodeMain] ERROR b.c.a.m.AppSetupWithP2PAndDAO: An error occurred: Error=bisq.core.dao.node.full.RpcException: java.lang.NoSuchMethodError: com.google.common.util.concurrent.Futures.addCallback(Lcom/google/common/util/concurrent/ListenableFuture;Lcom/google/common/util/concurrent/FutureCallback;)V

oscarguindzberg · 2019-05-20T00:41:59Z

I just:

rebased from master
Excluded guava dependency from btcd-cli4j

Once bisq-network/btcd-cli4j#4 is merged I can update this pull request to use the latest btcd-cli4j version

ripcurlx · 2019-05-30T17:59:44Z

I just:

rebased from master

Excluded guava dependency from btcd-cli4j

Once bisq-network/btcd-cli4j#4 is merged I can update this pull request to use the latest btcd-cli4j version

@oscarguindzberg Do you want to update the PR with the latest btcd-cli4j version before the merge?

…eady included by bisq.

…tly() to match WalletAppKit.

…ameter.

… of InetAddress+port.

- WalletConfig was rewritten from scratch based on bitcoinj 0.15 WalletAppKit. - bitcoinj 0.15 allows bip32 custom paths by constructor parameters, some subclasses were removed.

…ansaction.getTxId().toString().

…ion.getTxId().

…ethods.

…inal DefaultRiskAnalysis.

oscarguindzberg · 2019-05-30T18:32:11Z

@ripcurlx Just updated the PR to use the latest btcd-cli4j. I also did a rebase from master

wiz · 2019-08-25T09:50:44Z

It's been a few months, what's the status of this PR?

devinbileck · 2019-08-26T16:25:47Z

It was/is mostly ready, aside from thorough testing. It is stalled because we no longer have a bitcoinj maintainer and would be a risk to merge without one.

wiz · 2019-08-27T10:24:47Z

I agree it seems a significant risk with no immediate benefit, even for the SegWit use case there are many other issues to consider such as how Bisq P2P clients that don't support SegWit wouldn't be able to verify those transactions - I guess it would hard-fork the Bisq P2P network ?

yoshimo · 2019-08-27T13:19:55Z

I agree it seems a significant risk with no immediate benefit, even for the SegWit use case there are many other issues to consider such as how Bisq P2P clients that don't support SegWit wouldn't be able to verify those transactions - I guess it would hard-fork the Bisq P2P network ?

I don't know if it is possible to see the version distribution, but even if we can't there is a significant difference between an updated library , implementing segwit and actually using segwit and its new adress-formats.
You can do it in stages and wait a certain time until enough users probably updated their client.

bodymindarts · 2019-09-04T06:58:42Z

bitcoinj has had some patch releases in the meantime (0.15.2, 0.15.3) I have created a branch that rebases the bisq specific changes to bitcoinj ontop of the 0.15.3 release.
I suggest using that version as the bases for this PR.

I am going to now try and rebase this PR ontop of bisq master and apply the 0.15.3-bisq bitcoinj version from my branch to hopeful move this work along.

ripcurlx · 2019-11-26T15:09:13Z

As we decided to close PRs with no activity > 30 days, I'll close this PR for now. Feel free to reopen it when it is ready to be merged again.

oscarguindzberg requested review from cbeams, ManfredKarrer and ripcurlx as code owners April 23, 2019 18:39

oscarguindzberg mentioned this pull request Apr 23, 2019

Support for Bitcoin Bech32 SegWit addresses #1139

Closed

ManfredKarrer removed the request for review from cbeams April 23, 2019 23:12

ManfredKarrer changed the title ~~Use bisq's bitcoinj 0.15.1~~ [WIP] Use bisq's bitcoinj 0.15.1 Apr 23, 2019

ripcurlx added the in:wallet label Apr 24, 2019

This was referenced May 8, 2019

Cycle 1 bisq-network/compensation#283

Closed

Bisq Bitcoinj Fork Maintainer bisq-network/roles#8

Open

bisq's bitcoinj status bisq-network/bitcoinj#33

Open

oscarguindzberg force-pushed the bitcoinj_0_15 branch 2 times, most recently from 04af88a to a5a272d Compare May 9, 2019 20:22

ManfredKarrer approved these changes May 14, 2019

View reviewed changes

ManfredKarrer changed the title ~~[WIP] Use bisq's bitcoinj 0.15.1~~ Use bisq's bitcoinj 0.15.1 May 14, 2019

devinbileck mentioned this pull request May 16, 2019

Proposed dev priorities bisq-network/proposals#91

Closed

This was referenced May 19, 2019

Use latest guava 27 bisq-network/btcd-cli4j#4

Merged

Show more details about connected peers within Settings > Network Info #2457

Closed

oscarguindzberg requested a review from sqrrm as a code owner May 19, 2019 23:59

oscarguindzberg force-pushed the bitcoinj_0_15 branch from 9e42c5e to 3e1351b Compare May 20, 2019 00:36

oscarguindzberg added 5 commits May 30, 2019 15:07

Remove bcprov-jdk15on dependency, already included by bcpg-jdk15on

ac30a49

Use bitcoinj 0.15.1 (commit 40c9898)

8456d3d

bitcoinj 0.15: Update depencencies to match bitcoinj versions

77d7468

bitcoinj 0.15: bitcoinj exclude dependency bcprov-jdk15on because alr…

3c4b305

…eady included by bisq.

bitcoinj 0.15: Update modified dependencies hashes.

3b91937

oscarguindzberg added 15 commits May 30, 2019 15:07

bitcoinj 0.15: Replace Utils.closeUnchecked() to Closeables.closeQuie…

42855e3

…tly() to match WalletAppKit.

bitcoinj 0.15: Use PeerAddress constructor with NetworkParameters par…

6701471

…ameter.

bitcoinj 0.15: PeerAddress: don't set addr when already using hostname.

16adf40

bitcoinj 0.15: PeerAddress: Use InetSocketAddress constructor instead…

ac4c9ec

… of InetAddress+port.

bitcoinj 0.15: PeerAddress: BtcNodeConverterTest fixes.

102796a

bitcoinj 0.15: Bip44 refactor.

cc2ce1b

- WalletConfig was rewritten from scratch based on bitcoinj 0.15 WalletAppKit. - bitcoinj 0.15 allows bip32 custom paths by constructor parameters, some subclasses were removed.

bitcoinj 0.15: Remove call to PeerGroup.setIgnoreHttpSeeds(true).

e2e19cd

bitcoinj 0.15: Replace deprecated Transaction.getHashAsString with Tr…

b87bcdf

…ansaction.getTxId().toString().

bitcoinj 0.15: Replace deprecated Transaction.getHash() with Transact…

7ca68b5

…ion.getTxId().

bitcoinj 0.15: Fix TransactionAwareTradeTest

a36a80a

bitcoinj 0.15: Replace deprecated Script methods with ScriptPattern m…

c286979

…ethods.

bitcoinj 0.15: BisqRiskAnalisys: Add commented out code to match orig…

7abcf2d

…inal DefaultRiskAnalysis.

Use bitcoinj 0.15.1 (commit 199df6c)

1b1bf57

Prevent seednode to use older guava version

3e7fe90

Update btcd-cli4j to fb933fd

1a5cf2e

oscarguindzberg force-pushed the bitcoinj_0_15 branch from 3e1351b to 1a5cf2e Compare May 30, 2019 18:25

devinbileck mentioned this pull request Jun 7, 2019

For Cycle 2 bisq-network/compensation#295

Closed

devinbileck mentioned this pull request Jul 8, 2019

For Cycle 3 bisq-network/compensation#309

Closed

ripcurlx changed the title ~~Use bisq's bitcoinj 0.15.1~~ [WIP] Use bisq's bitcoinj 0.15.1 Jul 15, 2019

ripcurlx closed this Nov 26, 2019

cd2357 mentioned this pull request May 8, 2020

User can set custom tx fee to override FeeService estimated fee #4231

Closed

This was referenced May 19, 2020

[WIP] Use bisq's bitcoinj 0.15.8 #4270

Closed

Segwit support plan bisq-network/proposals#226

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Use bisq's bitcoinj 0.15.1 #2772

[WIP] Use bisq's bitcoinj 0.15.1 #2772

oscarguindzberg commented Apr 23, 2019

ManfredKarrer commented Apr 23, 2019

nopara73 commented Apr 24, 2019

ManfredKarrer commented Apr 27, 2019

ManfredKarrer left a comment

devinbileck commented May 19, 2019

oscarguindzberg commented May 20, 2019

ripcurlx commented May 30, 2019

oscarguindzberg commented May 30, 2019

wiz commented Aug 25, 2019

devinbileck commented Aug 26, 2019

wiz commented Aug 27, 2019

yoshimo commented Aug 27, 2019

bodymindarts commented Sep 4, 2019

ripcurlx commented Nov 26, 2019

[WIP] Use bisq's bitcoinj 0.15.1 #2772

[WIP] Use bisq's bitcoinj 0.15.1 #2772

Conversation

oscarguindzberg commented Apr 23, 2019

ManfredKarrer commented Apr 23, 2019

nopara73 commented Apr 24, 2019

ManfredKarrer commented Apr 27, 2019

ManfredKarrer left a comment

Choose a reason for hiding this comment

devinbileck commented May 19, 2019

oscarguindzberg commented May 20, 2019

ripcurlx commented May 30, 2019

oscarguindzberg commented May 30, 2019

wiz commented Aug 25, 2019

devinbileck commented Aug 26, 2019

wiz commented Aug 27, 2019

yoshimo commented Aug 27, 2019

bodymindarts commented Sep 4, 2019

ripcurlx commented Nov 26, 2019