Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doichain: set p2shHeader. #2728

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Doichain: set p2shHeader. #2728

merged 1 commit into from
Apr 17, 2019

Conversation

oscarguindzberg
Copy link
Contributor

See https://github.com/Doichain/core/blob/master/src/chainparams.cpp#L181

Not setting the p2shHeader makes the p2shHeader to be 0, that has problems on address validation on bitcoinj 0.15

ManfredKarrer
ManfredKarrer reviewed Apr 17, 2019
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 487f714 into bisq-network:master Apr 17, 2019
@oscarguindzberg oscarguindzberg mentioned this pull request May 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarguindzberg @ManfredKarrer