-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Updated netlayer, jtorctl and tor-binary #2499
Conversation
@freimair If a PR is not ready for merge/review please mark them with prefix WIP and use the draft feature (new in GH - when you create the PR you can select it as draft) |
@ManfredKarrer the PR is ready for merging and review. That is exaclty the point. I cannot test on OSX neither can I test on Windows. The reviewing process is meant to make it unlikely that a merge does break master. So please review and make it unlikely that the merge is going to break master by testing on OSX for example. |
ah yes, and although the Tor spec says that with this new version the default HS addresses are of the new format, a short chat with a tor dev resulted in https://trac.torproject.org/projects/tor/ticket/29669. so no worries. we are still with the old address format |
@freimair Did a quick test and all looks ok on OSX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Changes
Before merging
We need a tester for each platform. I did my linux part and it works nicely.
Missing tests:
The testing effort needed is simply building bisq and starting it up. If that works (or at least no other than it did before), the branch can be merged.