Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed node repo refactoring #2476

Merged
merged 5 commits into from
Mar 7, 2019
Merged

Seed node repo refactoring #2476

merged 5 commits into from
Mar 7, 2019

Conversation

freimair
Copy link
Member

shame on me...

This was referenced Feb 28, 2019
Closed
Merged
freimair referenced this pull request Feb 28, 2019
@ManfredKarrer
Revert 2473067
a9ee15d 
Seed nodes do not connect to correct network. The PR needs to be better
tested and fixed.
@ManfredKarrer ManfredKarrer changed the title Seed node repo refactoring WIP Seed node repo refactoring Mar 1, 2019
@ManfredKarrer
Copy link
Member

@ripcurlx Lets delay that after release so we keep test efforts low.

@ManfredKarrer ManfredKarrer added this to the v0.9.6 milestone Mar 1, 2019
@freimair freimair force-pushed the seedNodeRepo_refactoring branch 2 times, most recently from ac48a5e to 27258c8 Compare March 6, 2019 08:26
@freimair freimair mentioned this pull request Mar 6, 2019
Closed
@freimair freimair changed the title WIP Seed node repo refactoring Seed node repo refactoring Mar 6, 2019
ManfredKarrer
ManfredKarrer suggested changes Mar 6, 2019
View reviewed changes
Copy link
Member

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I use a localhost seed node it tries to connect to one of the onion addresses.

We send a PreliminaryGetDataRequest to peer rxdkppp3vicnbgqt.onion:8002.

Seems the handling for localhost is missing something.

@ManfredKarrer
Copy link
Member

Are the duplicated resources in the test/resource directory needed? Might cause consfusion...

@ManfredKarrer
Copy link
Member

With a dev DAO_TESTNET seed it worked. Have not tested yet with the live seeds....

@freimair
Copy link
Member Author

freimair commented Mar 7, 2019 •
edited
Loading

If I use a localhost seed node it tries to connect to one of the onion addresses.

how do you specify that you want to use a localhost seed node?

  • --useLocalhostForP2P?
    if so, that no longer works. We talked about that and not having peers like localhost:4001 in the code base. If you want to use localhost seednodes you have to add them manually like --seedNodes=<host:port[,...]>

I would like to get rid of these dev-related command line parameters as far as possible before a shiny and user-friendly Bisq 1.0 is released...

Are the duplicated resources in the test/resource directory needed?

for testing. tests do not have access to the main resources.

ManfredKarrer
ManfredKarrer approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@ManfredKarrer ManfredKarrer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK Cannot get localhost dev setup running.

core/src/main/resources/btc_regtest.seednodes Outdated Show resolved Hide resolved
@ManfredKarrer ManfredKarrer self-requested a review March 7, 2019 16:45
@ManfredKarrer
Copy link
Member

Dman, my #d9f9baf commit done on GH has committed to Bisq master instead to your PR. So I will merge now and try to find the issue why localhost is not working....

@ManfredKarrer ManfredKarrer merged commit 1a29dbe into bisq-network:master Mar 7, 2019
@freimair
Copy link
Member Author

freimair commented Mar 8, 2019

ahm ok, but are you sure? I see your commit in my branch...

@freimair freimair deleted the seedNodeRepo_refactoring branch March 8, 2019 14:29
@ManfredKarrer
Copy link
Member

Don't know exactly what went wrong....

freimair added a commit to freimair/bisq-docs that referenced this pull request Jul 20, 2019
@freimair
Removed deprecated --myAddress arg
03ce827 
--myAddress has been removed in bisq-network/bisq#2476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer Awaiting requested review from ManfredKarrer

Assignees
No one assigned
Labels
a:refactoring
Projects
None yet
Milestone
v0.9.6
Development

Successfully merging this pull request may close these issues.
3 participants
@freimair @ManfredKarrer @ripcurlx