Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API over TOR #2470

Merged
merged 1 commit into from
Mar 1, 2019
Merged

API over TOR #2470

merged 1 commit into from
Mar 1, 2019

Conversation

blabno
Copy link

@blabno blabno commented Feb 26, 2019

No description provided.

ManfredKarrer
ManfredKarrer reviewed Feb 26, 2019
View reviewed changes
Copy link
Member

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you got feedback from @freimair about that approach?

@ManfredKarrer
Copy link
Member

@blabno @freimair Please have a discussion what is the best approach to support a hiddenservice for the API. Goal is to not add any security, performance or stability risks for the P2P network. Also we don't want to get code dependencies from API code to normal app as we will likely deliver 2 binaries: one with the API and one without API (and without any code dependencies).

freimair
freimair approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had a call with @blabno. Everything seems fine. No obvious risks get introduced. The P2P network remains untouched.

utAck

@freimair freimair mentioned this pull request Feb 28, 2019
Closed
@ManfredKarrer ManfredKarrer changed the title API over TOR WIP API over TOR Mar 1, 2019
@ManfredKarrer ManfredKarrer changed the title WIP API over TOR API over TOR Mar 1, 2019
ManfredKarrer
ManfredKarrer approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer
Copy link
Member

Had a discussion with @freimair about that.
Summary:
This approach tells Tor to start a new HS and proxy the traffic to the API port, so not even a socket gets created from the Java side. Seems to have no risk and very low performance costs.

@ManfredKarrer ManfredKarrer merged commit 5ca73fc into bisq-network:http-api Mar 1, 2019
@blabno blabno deleted the api-tor branch March 4, 2019 13:18
@freimair freimair mentioned this pull request Mar 31, 2019
Closed
@freimair freimair mentioned this pull request Sep 5, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer approved these changes

@freimair freimair freimair approved these changes

Assignees
No one assigned
Labels
in:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blabno @ManfredKarrer @freimair