Dao serverside regtest #2447
Merged
Dao serverside regtest #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set BTC_DAO_TESTNET as last enum to not break existing regtest port convention which is derived from enum order - Remove BaseCurrencyNetwork.isBitcoin as always true -
ManfredKarrer
requested review from
ripcurlx,
devinbileck,
oscarguindzberg and
sqrrm
- As teh network is used for filtering asset types BSQ has 3 asset types, one per network we need to use REGTEST as network. The methods for checking which BaseCurrencyNetwork are using name() now instead of network as we have 2 times REGTEST. - Fix bug with not calling showFeeInfoAndPublishMyProposal for bonded role proposals.
|
Tested more now. So I think it is ready for merge after review. |
devinbileck
approved these changes
Feb 21, 2019
|
ACK - even it is already merged 😉 |
|
utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As testnet is un-usable ;-( I have setup a regtest network for DAO testing.
1 master node which Bitcoind only. A script creates all 9-11 minutes a new block
4 seed nodes connecting only to that the node.
1 explorer node (https://explorer.bisq.network/testnet/) connecting only to the master node.
I added a new basecurrency enum DAO_TESTNET which is technically a regtest but uses the IP of the master node for the bitcoin connection.
It is important that nobody creates blocks and connects to the master node to avoid disruption. By controlling block creation with a script on only one node we can easier test reorg scenarios.
We are aware that this regtest set up is less realistic as mainnet, but the alternative to create a real testnet with mining nodes would have been much more effort and involve compiling of bitcoind.
I am still testing all so please don't merge yet but welcome to review and help testing.
The user can select the DAO TESTNET in settings same as with TESTNET.
I will send by email to the main testers a data directory with full wallets (BTC and BSQ) ;-).
Testnet will not work anymore as no seed nodes are running anymore.