Download rpm package on RedHat-based Linux #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the download update task will download the deb package for any Linux distribution. Not only is this incorrect, but now that we are able to provide an rpm package (see bisq-network#2200), the download update task needs to be able to differentiate Linux distributions and provide the appropriate package. The download update task will now differentiate between Debian and RedHat based distributions (the two distributions for which we have an install package) and download the appropriate package. In addition, the isSupportedOS method was changed to exclusively check for Debian and RedHat based distributions, as opposed to just Linux in general. This means that any other distribution will encounter the following error, which seems appropriate: > Unable to determine the correct installer. Please download and verify manually at https://bisq.network/downloads
|
This is still a work in progress as I need to test my method of determining the appropriate distributions. If anyone is able to test on some distributions, that would be appreciated! |
|
I have tested this and it properly downloads the deb on Ubuntu 18.04. I was going to test on Fedora 29, but encountered #2279. I did verify the |
devinbileck
changed the title
|
Is this ready for merge despite #2279? |
|
Yes it is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the download update task will download the deb package for
any Linux distribution. Not only is this incorrect, but now that we are
able to provide an rpm package (see #2200), the download update task
needs to be able to differentiate Linux distributions and provide
the appropriate package.
The download update task will now differentiate between Debian and
RedHat based distributions (the two distributions for which we have an
install package) and download the appropriate package.
In addition, the isSupportedOS method was changed to exclusively check
for Debian and RedHat based distributions, as opposed to just Linux in
general. This means that any other distribution will encounter the
following error, which seems appropriate: