Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect progress listener for spv file resync #2424

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

ManfredKarrer
Copy link
Contributor

  • Rename model.getBtcSyncProgress() to model.getCombinedSyncProgress()
    to reflect correct property
  • Use bisqSetup.getBtcSyncProgress() instead of
    getCombinedSyncProgress() in showFirstPopupIfResyncSPVRequested as we
    need to listen to btc progress only not DAO progress.

@ripcurlx This is a bug fix for spv file resync.

- Rename model.getBtcSyncProgress() to model.getCombinedSyncProgress()
to reflect correct property
- Use bisqSetup.getBtcSyncProgress() instead of
getCombinedSyncProgress() in showFirstPopupIfResyncSPVRequested as we
need to listen to btc progress only not DAO progress.
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 9edd4cf into bisq-network:master Feb 16, 2019
@ManfredKarrer ManfredKarrer deleted the fix-spv-restore-issue branch February 17, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants