Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indication that BSQ transactions are not up to date #2388

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Feb 7, 2019

Fixes #2303.

Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

I have tested and it works, but I still think it would be better with a separate service for the sync handling to not pollute the setup class.

/**
* High level entry point for Dao domain.
* We initialize all main service classes here to be sure they are started.
*/
public class DaoSetup {
public class DaoSetup implements DaoStateListener {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to make a separate BSQSyncService or something like that, it feels wrong to add this to the DaoSetup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not use DaoSetup for that but DaoFacade (or some custom class). I will have a look soon into it to make a more concrete sugestion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I also wasn't quite happy to put it in this place, I just though to make it consistent how it is handled with the btcInfo WalletSetup right now:

// Wallet
public StringProperty getBtcInfo() {
return walletAppSetup.getBtcInfo();
}
public DoubleProperty getBtcSyncProgress() {
return walletAppSetup.getBtcSyncProgress();
}

private final StringProperty btcInfo = new SimpleStringProperty(Res.get("mainView.footer.btcInfo.initializing"));

How do we differentiation between a Facade and a Service atm in Bisq?
I'll have a look to find a better place for this presentation logic. I might change the implementation of the btcInfo/btcSyncProgress on the way as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the code into the DaoPresentation class which I created already for another DAO related PR.

@ripcurlx ripcurlx force-pushed the add-indication-for-unparsed-bsq-transactions branch from 8579fbd to d6b1863 Compare February 11, 2019 09:47
@ripcurlx ripcurlx force-pushed the add-indication-for-unparsed-bsq-transactions branch from d6b1863 to 6bea5da Compare February 11, 2019 09:59
@ripcurlx ripcurlx merged commit 14d5330 into bisq-network:master Feb 11, 2019
@ripcurlx ripcurlx deleted the add-indication-for-unparsed-bsq-transactions branch December 18, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants