Dao permute blindvotelist if not majority hash #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why travis was complaining as in that PR the throws is not needed. I added it as in another PR the exception handling is changed and then its needed anyway. Hope Travis gets with the update its cache cleaned.... |
…hash # Conflicts: # core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java
sqrrm
approved these changes
Feb 3, 2019
| * @param <T> Type of list items | ||
| * @return List of possible permutations of the original list | ||
| */ | ||
| public static <T> List<List<T>> findAllPermutations(List<T> list, int maxIterations) { |
There was a problem hiding this comment.
This function will build permutations starting from shorter lists. If it reaches the max number of permutations it will skip the more likely cases with regard to voting. It's more likely that one or a few votes are missing rather than most of them.
There was a problem hiding this comment.
Yes agree. Not trivial though to optimize it in that direction...
Co-Authored-By: ManfredKarrer <[email protected]>
Co-Authored-By: ManfredKarrer <[email protected]>
Co-Authored-By: ManfredKarrer <[email protected]>
Co-Authored-By: ManfredKarrer <[email protected]>
Co-Authored-By: ManfredKarrer <[email protected]>
Co-Authored-By: ManfredKarrer <[email protected]>
Co-Authored-By: ManfredKarrer <[email protected]>
Co-Authored-By: ManfredKarrer <[email protected]>
…-majority-hash' into dao-permute-blindvotelist-if-not-majority-hash
ManfredKarrer
deleted the
dao-permute-blindvotelist-if-not-majority-hash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.